Bug 1246988

Summary:	sharding - Populate the aggregated ia_size and ia_blocks before unwinding (f)setattr to upper layers
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	sharding	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.3	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1246082	Environment:
Last Closed:	2015-07-30 09:50:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1246082
Bug Blocks:

Description Krutika Dhananjay 2015-07-27 06:11:04 UTC

+++ This bug was initially created as a clone of Bug #1246082 +++

Description of problem:
Sharding translator does not aggregate ia_size and ia_blocks in the cbks of (f)setattr. And fuse copies out poststat into the fuse output header before writing the response to /dev/fuse. This was causing issues with OS installation on vm images with sharded volumes.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a dis-rep volume with sharding enabled and also all the options that need to be set which are documented at http://www.gluster.org/community/documentation/index.php/Libgfapi_with_qemu_libvirt.
2. Create a vm image on the volume.
3. Try to install (any) OS on this newly created image using virt-install CLI.
4. Open the UI on virt-manager and resume installation.
5. The application fails to recognise the virtio disk that is associated with the image.

Actual results:


Expected results:


Additional info:

--- Additional comment from Krutika Dhananjay on 2015-07-24 02:39:44 EDT ---

http://review.gluster.org/#/c/11754/

--- Additional comment from Anand Avati on 2015-07-27 02:06:32 EDT ---

COMMIT: http://review.gluster.org/11754 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit fd296d90168002a475a9899a72a0dd1811f038ee
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Jul 23 14:59:19 2015 +0530

    posix,shard: Fill in ia_size and ia_blocks before unwinding (f)setattr
    
    The shard xlator will request for size xattrs in its request and
    posix will perform xattr_fill of requested keys before unwinding
    (f)setattr.
    
    Change-Id: I4ec4779568be6f805724b875b1b4215787112e7f
    BUG: 1246082
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/11754
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 1 Anand Avati 2015-07-27 06:25:37 UTC

REVIEW: http://review.gluster.org/11765 (posix,shard: Fill in ia_size and ia_blocks before unwinding (f)setattr) posted (#1) for review on release-3.7 by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2015-07-27 08:59:02 UTC

COMMIT: http://review.gluster.org/11765 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit f47e527db2d424a4bbe0b1e2e89106ac5d60cdea
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Jul 23 14:59:19 2015 +0530

    posix,shard: Fill in ia_size and ia_blocks before unwinding (f)setattr
    
            Backport of: http://review.gluster.org/11754
    
    The shard xlator will request for size xattrs in its request and
    posix will perform xattr_fill of requested keys before unwinding
    (f)setattr.
    
    Change-Id: I1a4c655bee99fb0d6c03062d876b36816282c2b0
    BUG: 1246988
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/11765
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>

Comment 3 Kaushal 2015-07-30 09:50:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user