Bug 1247464

Summary:	store disk vendor and model separately
Product:	[Retired] Beaker	Reporter:	Dan Callaghan <dcallagh>
Component:	inventory	Assignee:	beaker-dev-list
Status:	CLOSED WONTFIX	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	low
Version:	20	CC:	cbouchar, mjia
Target Milestone:	---	Keywords:	FutureFeature, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-19 21:28:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Callaghan 2015-07-28 05:10:33 UTC

Currently the Beaker data model has a single "model" field for disks. IDE disks report just a single 40-char model but SCSI disks actually have separate vendor and model fields (although it seems that very often the vendor value is just rubbish).

Separate vendor and model also more closely matches the generic lshw data model for devices, and when we get the disk info from lshw (bug 902567) we have the vendor and model separated already, so we should store it in Beaker that way.

There are some backwards compatibility implications which I am not sure about though.

Comment 1 Dan Callaghan 2015-07-28 05:22:51 UTC

Actually reality seems to be a bit messier than that, the SCSI vendor for SATA disks appears to be often (always?) set to just ATA with the actual vendor in the model field. For example right now we have things like this from parted:

ATA WDC WD10EZEX-60Z
ATA Maxtor 6L250S0
ATA ST380815AS

where WDC = Western Digital and ST = Seagate(?). lshw has a pile of heuristics to discard the useless "ATA" vendor string and determine the actual vendor from the common prefixes.

So the right solution is indeed to go with the vendor/model from lshw (and continue to improve lshw's heuristics where necessary to give cleaned-up useful vendor and model information).