Bug 1247464 - store disk vendor and model separately
store disk vendor and model separately
Status: NEW
Product: Beaker
Classification: Community
Component: inventory (Show other bugs)
20
Unspecified Unspecified
low Severity unspecified (vote)
: ---
: ---
Assigned To: beaker-dev-list
tools-bugs
: FutureFeature, Triaged
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2015-07-28 01:10 EDT by Dan Callaghan
Modified: 2015-11-17 18:55 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Dan Callaghan 2015-07-28 01:10:33 EDT
Currently the Beaker data model has a single "model" field for disks. IDE disks report just a single 40-char model but SCSI disks actually have separate vendor and model fields (although it seems that very often the vendor value is just rubbish).

Separate vendor and model also more closely matches the generic lshw data model for devices, and when we get the disk info from lshw (bug 902567) we have the vendor and model separated already, so we should store it in Beaker that way.

There are some backwards compatibility implications which I am not sure about though.
Comment 1 Dan Callaghan 2015-07-28 01:22:51 EDT
Actually reality seems to be a bit messier than that, the SCSI vendor for SATA disks appears to be often (always?) set to just ATA with the actual vendor in the model field. For example right now we have things like this from parted:

ATA WDC WD10EZEX-60Z
ATA Maxtor 6L250S0
ATA ST380815AS

where WDC = Western Digital and ST = Seagate(?). lshw has a pile of heuristics to discard the useless "ATA" vendor string and determine the actual vendor from the common prefixes.

So the right solution is indeed to go with the vendor/model from lshw (and continue to improve lshw's heuristics where necessary to give cleaned-up useful vendor and model information).

Note You need to log in before you can comment on or make changes to this bug.