Bug 1248110
| Summary: | Review Request: python-process-tests - Tools for testing processes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | José Matos <jamatos> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jamatos, package-review |
| Target Milestone: | --- | Flags: | jamatos:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-process-tests-1.0.0-2.fc24 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-29 18:16:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Orion Poplawski
2015-07-29 15:36:50 UTC
Hi Orion,
this is nice package. :-)
I have just a small remark, you are owning %{python3_sitelib}/__pycache__ and according to the guideline you should not. That is you should own the files but not the directory. https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling
The suggestion is then to replace
%{python3_sitelib}/*
by
%{python3_sitelib}/__pycache__/*
%{python3_sitelib}/%{srcname}*egg-info
%{python3_sitelib}/*.py
Or equivalent, you choose. :-)
Ah, good catch. * Wed Jul 29 2015 Orion Poplawski <orion.com> - 1.0.0-2 - Do not own python3 __pycache__ dir Spec URL: http://www.cora.nwra.com/~orion/fedora/python-process-tests.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-process-tests-1.0.0-2.fc24.src.rpm For aesthetic reasons I would choose:
%{python3_sitelib}/%{name}*
instead of
%{python3_sitelib}/process_tests*
but then the beauty is in the eye of the beholder. :-D
The package is approved. :-)
except that %{name} != process_tests. It seems upstream is a bit inconsistent here too.
New Package SCM Request
=======================
Package Name: python-process-tests
Short Description: Toosl for testing processes
Upstream URL: https://github.com/ionelmc/python-process-tests
Owners: orion
Branches: f22 f23 epel7
InitialCC:
Git done (by process-git-requests). Checked in and built. Thanks all. |