Bug 1248110 - Review Request: python-process-tests - Tools for testing processes
Review Request: python-process-tests - Tools for testing processes
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: José Matos
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2015-07-29 11:36 EDT by Orion Poplawski
Modified: 2015-07-29 14:16 EDT (History)
2 users (show)

See Also:
Fixed In Version: python-process-tests-1.0.0-2.fc24
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-07-29 14:16:11 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jamatos: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Orion Poplawski 2015-07-29 11:36:50 EDT
Spec URL: http://www.cora.nwra.com/~orion/fedora/python-process-tests.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-process-tests-1.0.0-1.fc24.src.rpm
Description: 
Tools for testing processes.

Fedora Account System Username: orion
Comment 1 José Matos 2015-07-29 12:27:12 EDT
Hi Orion,
  this is nice package. :-)

I have just a small remark, you are owning %{python3_sitelib}/__pycache__ and according to the guideline you should not. That is you should own the files but not the directory. https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling

The suggestion is then to replace

%{python3_sitelib}/*

by

%{python3_sitelib}/__pycache__/*
%{python3_sitelib}/%{srcname}*egg-info
%{python3_sitelib}/*.py

Or equivalent, you choose. :-)
Comment 2 Orion Poplawski 2015-07-29 12:37:16 EDT
Ah, good catch.

* Wed Jul 29 2015 Orion Poplawski <orion@cora.nwra.com> - 1.0.0-2
- Do not own python3 __pycache__ dir

Spec URL: http://www.cora.nwra.com/~orion/fedora/python-process-tests.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-process-tests-1.0.0-2.fc24.src.rpm
Comment 3 José Matos 2015-07-29 12:50:57 EDT
For aesthetic reasons I would choose:

%{python3_sitelib}/%{name}*

instead of

%{python3_sitelib}/process_tests*

but then the beauty is in the eye of the beholder. :-D

The package is approved. :-)
Comment 4 Orion Poplawski 2015-07-29 13:01:37 EDT
except that %{name} != process_tests.  It seems upstream is a bit inconsistent here too.

New Package SCM Request
=======================
Package Name: python-process-tests
Short Description: Toosl for testing processes
Upstream URL: https://github.com/ionelmc/python-process-tests
Owners: orion
Branches: f22 f23 epel7
InitialCC:
Comment 5 Gwyn Ciesla 2015-07-29 13:26:07 EDT
Git done (by process-git-requests).
Comment 6 Orion Poplawski 2015-07-29 14:16:11 EDT
Checked in and built.  Thanks all.

Note You need to log in before you can comment on or make changes to this bug.