Spec URL: http://www.cora.nwra.com/~orion/fedora/python-process-tests.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-process-tests-1.0.0-1.fc24.src.rpm Description: Tools for testing processes. Fedora Account System Username: orion
Hi Orion, this is nice package. :-) I have just a small remark, you are owning %{python3_sitelib}/__pycache__ and according to the guideline you should not. That is you should own the files but not the directory. https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling The suggestion is then to replace %{python3_sitelib}/* by %{python3_sitelib}/__pycache__/* %{python3_sitelib}/%{srcname}*egg-info %{python3_sitelib}/*.py Or equivalent, you choose. :-)
Ah, good catch. * Wed Jul 29 2015 Orion Poplawski <orion.com> - 1.0.0-2 - Do not own python3 __pycache__ dir Spec URL: http://www.cora.nwra.com/~orion/fedora/python-process-tests.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-process-tests-1.0.0-2.fc24.src.rpm
For aesthetic reasons I would choose: %{python3_sitelib}/%{name}* instead of %{python3_sitelib}/process_tests* but then the beauty is in the eye of the beholder. :-D The package is approved. :-)
except that %{name} != process_tests. It seems upstream is a bit inconsistent here too. New Package SCM Request ======================= Package Name: python-process-tests Short Description: Toosl for testing processes Upstream URL: https://github.com/ionelmc/python-process-tests Owners: orion Branches: f22 f23 epel7 InitialCC:
Git done (by process-git-requests).
Checked in and built. Thanks all.