Bug 1248735
| Summary: | Missing plotting dependencies | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Underwood <jonathan.underwood> |
| Component: | binwalk | Assignee: | Scott Talbert <swt> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 22 | CC: | ajax, mstuchli, swt |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 2.0.0-6.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-09-18 19:01:40 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1249368 | ||
| Bug Blocks: | |||
Looks like pyqtgraph will need to be packaged. I'll take a stab at packaging it. Great. If you cc me on the review request bug I'll review it for you. OK, now that pyqtgraph is mostly done, the question becomes - what to do with this? Given that binwalk functions without pyqtgraph, and I can see uses for it, say on a server without any GUI, I am hesitant to add a Requires or Recommends on pyqtgraph which would force pulling in a bunch of UI packages. I am leaning towards the following: add a Suggests on pyqtgraph and perhaps patch binwalk to catch the ImportError and add a message informing the user about the pyqtgraph package. Thoughts? I think your Suggests solution is good - that's exactly the route I'd follow (and is similar to what we recently did with inkscape and the latex plugin) binwalk-2.0.0-6.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14173 binwalk-2.0.0-6.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14174 binwalk-2.0.0-6.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update binwalk'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14174 binwalk-2.0.0-6.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update binwalk'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14173 binwalk-2.0.0-6.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. binwalk-2.0.0-6.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: $ binwalk -3 somefile Plotter Exception: No module named pyqtgraph.opengl ---------------------------------------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib64/python2.7/site-packages/binwalk/core/module.py", line 481, in main self.init() File "/usr/lib64/python2.7/site-packages/binwalk/modules/binvis.py", line 51, in init import pyqtgraph.opengl as gl ImportError: No module named pyqtgraph.opengl ---------------------------------------------------------------------------------------------------- Version-Release number of selected component (if applicable): binwalk-2.0.0-2.fc22.x86_64 How reproducible: everytime