Bug 1248735 - Missing plotting dependencies
Summary: Missing plotting dependencies
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: binwalk
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Scott Talbert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1249368
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-30 17:53 UTC by Jonathan Underwood
Modified: 2015-09-18 20:51 UTC (History)
3 users (show)

Fixed In Version: 2.0.0-6.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-09-18 19:01:40 UTC


Attachments (Terms of Use)

Description Jonathan Underwood 2015-07-30 17:53:42 UTC
Description of problem:
$ binwalk -3 somefile

Plotter Exception: No module named pyqtgraph.opengl
----------------------------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/binwalk/core/module.py", line 481, in main
    self.init()
  File "/usr/lib64/python2.7/site-packages/binwalk/modules/binvis.py", line 51, in init
    import pyqtgraph.opengl as gl
ImportError: No module named pyqtgraph.opengl
----------------------------------------------------------------------------------------------------



Version-Release number of selected component (if applicable):
binwalk-2.0.0-2.fc22.x86_64

How reproducible:
everytime

Comment 1 Scott Talbert 2015-07-30 23:44:42 UTC
Looks like pyqtgraph will need to be packaged.

Comment 2 Scott Talbert 2015-07-31 03:26:56 UTC
I'll take a stab at packaging it.

Comment 3 Jonathan Underwood 2015-07-31 09:12:37 UTC
Great. If you cc me on the review request bug I'll review it for you.

Comment 4 Scott Talbert 2015-08-08 14:13:34 UTC
OK, now that pyqtgraph is mostly done, the question becomes - what to do with this?

Given that binwalk functions without pyqtgraph, and I can see uses for it, say on a server without any GUI, I am hesitant to add a Requires or Recommends on pyqtgraph which would force pulling in a bunch of UI packages.  I am leaning towards the following: add a Suggests on pyqtgraph and perhaps patch binwalk to catch the ImportError and add a message informing the user about the pyqtgraph package.

Thoughts?

Comment 5 Jonathan Underwood 2015-08-08 15:00:52 UTC
I think your Suggests solution is good - that's exactly the route I'd follow (and is similar to what we recently did with inkscape and the latex plugin)

Comment 6 Fedora Update System 2015-08-25 01:23:27 UTC
binwalk-2.0.0-6.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14173

Comment 7 Fedora Update System 2015-08-25 01:23:40 UTC
binwalk-2.0.0-6.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14174

Comment 8 Fedora Update System 2015-08-26 04:26:04 UTC
binwalk-2.0.0-6.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update binwalk'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14174

Comment 9 Fedora Update System 2015-08-26 17:27:50 UTC
binwalk-2.0.0-6.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update binwalk'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14173

Comment 10 Fedora Update System 2015-09-18 19:01:39 UTC
binwalk-2.0.0-6.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2015-09-18 20:51:54 UTC
binwalk-2.0.0-6.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.