Bug 1249130
| Summary: | Non-ascii chars in the disk name break the template creation | |||
|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Carlos Mestre González <cmestreg> | |
| Component: | General | Assignee: | Idan Shaby <ishaby> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Aharon Canan <acanan> | |
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | --- | CC: | acanan, amureini, bazulay, bugs, ecohen, gklein, ikroshki, ishaby, lsurette, mgoldboi, nsoffer, rbalakri, rmcswain, sherold, tnisan, ycui, yeylon, ylavi | |
| Target Milestone: | ovirt-3.5.6 | Keywords: | Regression | |
| Target Release: | 3.5.6 | Flags: | rule-engine:
ovirt-3.5.z+
rule-engine: blocker+ sherold: planning_ack+ rule-engine: devel_ack+ rule-engine: testing_ack+ |
|
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | storage | |||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1257192 (view as bug list) | Environment: | ||
| Last Closed: | 2015-12-22 13:24:57 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1219680, 1260131 | |||
|
Description
Carlos Mestre González
2015-07-31 15:07:23 UTC
Talked to Yaniv Dary - this should just be blocked in UI+RESTAPI. Hi Allon, so just to clarify, creating of a template from a disk with non-ascii characters in the alias should be blocked, right? What about add/editing a disk's alias with non-ascii characters? Currently adding a disk with non-ascii characters fails, but update the disk alias pass. is this correct? Seems to me both actions should be the same (either allow or not) (In reply to Carlos Mestre González from comment #2) > so just to clarify, creating of a template from a disk with non-ascii > characters in the alias should be blocked, right? Probably, yes. > What about add/editing a disk's alias with non-ascii characters? Currently > adding a disk with non-ascii characters fails, but update the disk alias > pass. is this correct? Seems to me both actions should be the same (either > allow or not) Should all be blocked, IMHO. So is this bug going to be take care of the disk alias issue to? This is an issue in vdsm:
'ascii' codec can't encode character u'\xe9' in position 26: ordinal
not in range(128)
Vdsm should be fixed to encode unicode description properly.
(In reply to Nir Soffer from comment #5) > This is an issue in vdsm: > > 'ascii' codec can't encode character u'\xe9' in position 26: ordinal > not in range(128) True. > Vdsm should be fixed to encode unicode description properly. Also true - but insufficient to solve this bug. We cannot have newer engines breaking existing VDSMs. Nir/Idan - Please clone this bug to VDSM so we can pursue this direction upstream, regardless of the engine fix that's required for zstream. Since current vdsm does not support non-ascii description or even base64 (due to padding with "="), engine must avoid sending such data to vdsm. *** Bug 1259215 has been marked as a duplicate of this bug. *** *** Bug 1260131 has been marked as a duplicate of this bug. *** This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP. this bug has both 3.5.z & 3.6.0 flags, in bugzilla lang it means its a clone candidate from 3.6.0 to 3.5.z meaning it's pending a clone and wasn't fixed for 3.5.z. if this isn't the case, please fix flags accordingly, if it is the case, then please clone the bugs to 3.5.7 (3.5.6 was built already) After reading comment#3 and comment#7, it looks like we should block non ascii, Right now using vt18 it seems to work [1] (we do not block it) I am not sure i know what I should expect. Are we blocking it or not? [1] I create VM called "test" with disk called "áéíñ" and then created template from it. Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. Aharon,using non ascii characters in disk alias or description should work now. Should be easy to verify. (In reply to Nir Soffer from comment #14) > Aharon,using non ascii characters in disk alias or description should work > now. > > Should be easy to verify. Following above, verified (comment #12) oVirt 3.5.6 has been released and the bz verified, moving to closed current release. |