Bug 1250834

Summary:	Sharding - Excessive logging of messages of the kind 'Failed to get trusted.glusterfs.shard.file-size for bf292f5b-6dd6-45a8-b03c-aaf5bb973c50'
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	sharding	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.7.3	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1250441	Environment:
Last Closed:	2015-09-09 09:39:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1250441
Bug Blocks:	1248533

Description Krutika Dhananjay 2015-08-06 06:33:19 UTC

+++ This bug was initially created as a clone of Bug #1250441 +++

Description of problem:
On enabling features.shard on a volume which already has few files, performing operations on the mount is causing excessive logging of messages of the following kind:

[2015-08-05 10:57:48.743352] E [shard.c:232:shard_modify_size_and_block_count] 2-dis-shard: Failed to get trusted.glusterfs.shard.file-size for 0b2bd401-c438-4d57-8ae5-8d26105d3396

Turns out this is coming from readdir callback of shard translator where the translator unconditionally looks for the xattr 'trusted.glusterfs.shard.file-size' in every entry's rsp dict and logs this error on not finding it. But files that are not sharded (i.e., the ones that were created before sharding was enabled on the volume) will not (and should not!) have this xattr associated with them. So these logs are misleading and must be suppressed in readdir(p).
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-08-05 11:26:31 EDT ---

REVIEW: http://review.gluster.org/11843 (features/shard: Fix excessive logging in readdir(p) callback) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2015-08-05 22:37:10 EDT ---

COMMIT: http://review.gluster.org/11843 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 611b2545b012d1c5d0700af6bc1a182f7aa2343a
Author: Krutika Dhananjay <kdhananj>
Date:   Wed Aug 5 16:58:01 2015 +0530

    features/shard: Fix excessive logging in readdir(p) callback
    
    On enabling features.shard on a volume which already has few files,
    performing operations on the mount was causing excessive logging of
    messages of the following kind:
    
    [2015-08-05 10:57:48.743352] E [shard.c:232:shard_modify_size_and_block_count]
    2-dis-shard: Failed to get trusted.glusterfs.shard.file-size for
    0b2bd401-c438-4d57-8ae5-8d26105d3396
    
    Turns out this is coming from shard_readdir_cbk() where the shard
    translator unconditionally looks for the xattr
    'trusted.glusterfs.shard.file-size' in every entry's rsp dict and
    logs this error on not finding it. But files that are not sharded
    (i.e., the ones that were created before sharding was enabled on the volume)
    will not (and should not) have this xattr associated with them.
    So these logs are misleading and must be suppressed in readdir(p).
    
    Change-Id: I8d268b4f90a8bf744c7851f1984f5a1b6968fb6a
    BUG: 1250441
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/11843
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Gluster Build System <jenkins.com>

Comment 1 Anand Avati 2015-08-06 07:04:29 UTC

REVIEW: http://review.gluster.org/11850 (features/shard: Fix excessive logging in readdir(p) callback) posted (#1) for review on release-3.7 by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2015-08-07 07:20:19 UTC

COMMIT: http://review.gluster.org/11850 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit 6408e0e864261479e2a1466f27baba2105aab287
Author: Krutika Dhananjay <kdhananj>
Date:   Wed Aug 5 16:58:01 2015 +0530

    features/shard: Fix excessive logging in readdir(p) callback
    
            Backport of: http://review.gluster.org/#/c/11843/
    
    On enabling features.shard on a volume which already has few files,
    performing operations on the mount was causing excessive logging of
    messages of the following kind:
    
    [2015-08-05 10:57:48.743352] E [shard.c:232:shard_modify_size_and_block_count]
    2-dis-shard: Failed to get trusted.glusterfs.shard.file-size for
    0b2bd401-c438-4d57-8ae5-8d26105d3396
    
    Turns out this is coming from shard_readdir_cbk() where the shard
    translator unconditionally looks for the xattr
    'trusted.glusterfs.shard.file-size' in every entry's rsp dict and
    logs this error on not finding it. But files that are not sharded
    (i.e., the ones that were created before sharding was enabled on the volume)
    will not (and should not) have this xattr associated with them.
    So these logs are misleading and must be suppressed in readdir(p).
    
    Change-Id: I2f084023fc3a2a5147d7f364253290280b816db9
    BUG: 1250834
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/11850
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Kaushal 2015-09-09 09:39:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report.

glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user