Bug 1251467

Summary:	ec sequentializes all reads, limiting read throughtput
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	disperse	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.3	CC:	bugs, rtalur
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1245689	Environment:
Last Closed:	2016-02-15 07:38:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1245689
Bug Blocks:	1279240

Description Xavi Hernandez 2015-08-07 11:53:30 UTC

+++ This bug was initially created as a clone of Bug #1245689 +++

Description of problem:

ec needs to issue locks for reads, so it uses the same management functions used for writes. This means that reads are sent one by one in sequence. Since reads do not touch any state of the file, there could be multiple read requests running at the same time, improving read performance.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-07-22 17:12:09 CEST ---

REVIEW: http://review.gluster.org/11742 (cluster/ec: Allow read fops to be processed in parallel) posted (#1) for review on master by Xavier Hernandez (xhernandez)

--- Additional comment from Anand Avati on 2015-07-29 05:17:15 CEST ---

REVIEW: http://review.gluster.org/11742 (cluster/ec: Allow read fops to be processed in parallel) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-07-29 09:38:38 CEST ---

REVIEW: http://review.gluster.org/11742 (cluster/ec: Allow read fops to be processed in parallel) posted (#3) for review on master by Xavier Hernandez (xhernandez)

--- Additional comment from Anand Avati on 2015-08-06 13:26:34 CEST ---

REVIEW: http://review.gluster.org/11742 (cluster/ec: Allow read fops to be processed in parallel) posted (#4) for review on master by Xavier Hernandez (xhernandez)

Comment 1 Kaushal 2015-10-28 12:28:46 UTC

This bug could not be fixed in time for glusterfs-3.7.4 or glusterfs-3.7.5. This is now being tracked for being fixed in glusterfs-3.7.6.

Comment 2 Vijay Bellur 2015-10-28 13:40:58 UTC

REVIEW: http://review.gluster.org/12447 (cluster/ec: Allow read fops to be processed in parallel) posted (#2) for review on release-3.7 by Xavier Hernandez (xhernandez)

Comment 3 Raghavendra Talur 2015-11-08 20:27:26 UTC

This bug could not be fixed in time for glusterfs-3.7.6.
This is now being tracked for being fixed in glusterfs-3.7.7.

Comment 4 Vijay Bellur 2015-11-23 12:09:10 UTC

REVIEW: http://review.gluster.org/12447 (cluster/ec: Allow read fops to be processed in parallel) posted (#3) for review on release-3.7 by Xavier Hernandez (xhernandez)

Comment 5 Vijay Bellur 2015-11-25 03:03:21 UTC

COMMIT: http://review.gluster.org/12447 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit 69e74432ee1ab29ba7caf483450997a95920b729
Author: Xavier Hernandez <xhernandez>
Date:   Wed Jul 22 17:08:02 2015 +0200

    cluster/ec: Allow read fops to be processed in parallel
    
    Currently ec only sends a single read request at a time for a given
    inode. Since reads do not interfere between them, this patch allows
    multiple concurrent read requests to be sent in parallel.
    
    This is a backport of these patches:
    
    > Change-Id: If853430482a71767823f39ea70ff89797019d46b
    > BUG: 1245689
    > Signed-off-by: Xavier Hernandez <xhernandez>
    > Reviewed-on: http://review.gluster.org/11742
    > Tested-by: NetBSD Build System <jenkins.org>
    > Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    > Tested-by: Gluster Build System <jenkins.com>
    >
    > Change-Id: I6042129f09082497b80782b5704a52c35c78f44d
    > BUG: 1276031
    > Signed-off-by: Xavier Hernandez <xhernandez>
    
    Change-Id: I1b1146d1fd1828b12bfc566cd76e5ea110f8909b
    BUG: 1251467
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/12447
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 6 Kaushal 2016-04-19 07:46:47 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.7, please open a new bug report.

glusterfs-3.7.7 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-February/025292.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user