Bug 1251885

Summary: [zh_CN] Unexpected key strings (_P) (_E) in Edit-> Preference dialog.
Product: Red Hat Enterprise Linux 7 Reporter: Lijun Li <lijli>
Component: gnome-terminalAssignee: Debarshi Ray <debarshir>
Status: CLOSED ERRATA QA Contact: QE Internationalization Bugs <qe-i18n-bugs>
Severity: medium Docs Contact:
Priority: high    
Version: 7.2CC: lmiksik, mclasen, mkrajnak, noriko, qe-i18n-bugs, smaitra, sshedmak, vbenes
Target Milestone: rcKeywords: Translation
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: gnome-terminal-3.14.3-6.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-03 23:47:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1313485, 1340415    
Attachments:
Description Flags
Unexpected key strings (_P) (_E) in Preference dialog none

Description Lijun Li 2015-08-10 08:35:32 UTC
Description of problem:
[zh_CN] Unexpected key strings (_P) (_E) in Edit-> Preference dialog.

Version-Release number of selected component (if applicable):
gnome-terminal-3.14.3-1.el7.x86_64.rpm 

How reproducible:
100%

Steps to Reproduce:
1. Install latest rhel7.2 build and log in system with zh_CN locale.
2. Run terminal
3. Click Edit->Preference.

Actual results:
[zh_CN] Unexpected key strings (_P) (_E) in Edit-> Preference dialog.

Expected results:
They should be removed.

Additional info:
Please see the attached screen-shot.

Comment 1 Lijun Li 2015-08-10 08:36:50 UTC
Created attachment 1060965 [details]
Unexpected key strings (_P) (_E) in Preference dialog

Comment 3 Matthias Clasen 2015-09-28 18:26:04 UTC
These strings come directly out of the Chinese translation:

#: ../src/preferences.ui.h:5
msgid "Preferences"
msgstr "配置文件首选项(_P)"


#: ../src/preferences.ui.h:18
msgid "Encodings"
msgstr "编码(_E)"


This needs to be fixed in the .po file, ideally upstream. Adding "(_P)" as a suffix only makes sense if the string has a mnemonic underline in it to begin with.

Comment 4 Matthias Clasen 2015-09-28 18:30:44 UTC
I've filed an upstream bug for this issue.

Comment 7 Matthias Clasen 2016-04-05 14:24:52 UTC
Are you going to provide a patch for this ?

If it is sufficient to just take those upstream translations you showed and strip the (_E) from the one that still has it, we can do that ourselves, too.

Just let me know what you prefer

Comment 8 Noriko Mizumoto 2016-04-06 01:04:58 UTC
Hi Matthias

Red Hat Simplified Chinese (zh_CN) translator went through the PO, and suggested me to correct them as below. The translation for "Preferences" needs to be corrected, while "Encodings" looks fine.

msgid "Preferences"
 => 首选项 

msgid "Encodings"
 => 编码

Comment 12 errata-xmlrpc 2016-11-03 23:47:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2167.html