Bug 1252308
| Summary: | Issues in postfix pmda's search for mail log | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Miloš Prchlík <mprchlik> |
| Component: | pcp | Assignee: | Nathan Scott <nathans> |
| Status: | CLOSED ERRATA | QA Contact: | Miloš Prchlík <mprchlik> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.2 | CC: | brolley, fche, lberk, mbenitez, mcermak, mgoodwin, nathans |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-04 04:22:27 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
I made a tiny mistake, the correct messages in pmcd/postfix.log are: [Fri Aug 7 05:24:14] pmdapostfix(64056) Info: qshape cmd: qshape -b 10 -t 5 <qname> [Fri Aug 7 05:24:14] pmdapostfix(64056) Info: logfile: /var/log/mail [Fri Aug 7 05:24:14] pmdapostfix(64056) Error: Data read error on tailed file: Is a directory (In reply to Miloš Prchlík from comment #0) > [...] > Which makes sense, after some digging it was obvious that /var/log/mail - > present in @logfiles - is a directory. /var/log/mail is a directory, but > readable, therefore it's used in qshape calls. > Yep - easily defended against, fix headed upstream shortly. > > The second issue, pmdapostfix.pl, line 243 - I'm no friend with perl but I > think there should be $pmda: > > pmda->log("Fatal: No Postfix log file found in: @logfiles"); > Yes, good catch; perl is lenient on that, but also fixed upstream now. I wouldn't think these issues are high enough priority for a rebuild at this stage, but we can pick them up in the context of other patches if any are needed. thanks Miloš! Verified for build pcp-3.11.3-3.el7. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-2344.html |
Description of problem: The first issue that caught my attention, and caused my sanity test of postfix pmda to fail: test failed to install pmda, with these errors in pmcd/postfix.log: [Tue Aug 11 02:53:58] pmdapostfix(27796) Info: qshape cmd: qshape -b 10 -t 5 <qname> [Tue Aug 11 02:53:58] pmdapostfix(27796) Error: Data read error on tailed file: Is a directory Which makes sense, after some digging it was obvious that /var/log/mail - present in @logfiles - is a directory. /var/log/mail is a directory, but readable, therefore it's used in qshape calls. The second issue, pmdapostfix.pl, line 243 - I'm no friend with perl but I think there should be $pmda: pmda->log("Fatal: No Postfix log file found in: @logfiles"); Version-Release number of selected component (if applicable): pcp-pmda-postfix-3.10.6-1.el7 How reproducible: Always, on all arches Steps to Reproduce: 1. service pmcd start 2. cd /var/lib/pcp/pmdas/postfix && ./Install 3. Actual results: Expected results: Additional info: