Bug 1252586

Summary: Legacy files pre-existing tier attach must be promoted
Product: [Community] GlusterFS Reporter: Dan Lambright <dlambrig>
Component: tieringAssignee: Dan Lambright <dlambrig>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, nbalacha, sankarshan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1261146 1271705 (view as bug list) Environment:
Last Closed: 2016-06-16 13:30:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1260923, 1261146, 1271705    

Description Dan Lambright 2015-08-11 19:53:21 UTC
Files that exist before a tier is attached are called "legacy files". They should be promoted to the hot tier when accessed. In some cases they are not if the parent gfid (directory the file belongs in) is unavailable.

Comment 1 Anand Avati 2015-08-11 19:54:09 UTC
REVIEW: http://review.gluster.org/11828 (tier/ctr: Lookup heal of cold tier during attach tier) posted (#2) for review on master by Dan Lambright (dlambrig)

Comment 2 Anand Avati 2015-08-18 11:24:02 UTC
REVIEW: http://review.gluster.org/11828 (tier/ctr: Lookup heal of cold tier during attach tier) posted (#3) for review on master by Dan Lambright (dlambrig)

Comment 3 Anand Avati 2015-08-21 10:55:50 UTC
REVIEW: http://review.gluster.org/11828 (tier/ctr: Lookup heal of cold tier during attach tier) posted (#4) for review on master by Dan Lambright (dlambrig)

Comment 4 Anand Avati 2015-08-21 15:51:10 UTC
REVIEW: http://review.gluster.org/11828 (tier/ctr: Lookup heal of cold tier during attach tier) posted (#5) for review on master by Joseph Fernandes

Comment 5 Anand Avati 2015-08-27 17:14:14 UTC
REVIEW: http://review.gluster.org/11828 (tier/ctr: Lookup heal of cold tier during attach tier) posted (#6) for review on master by Dan Lambright (dlambrig)

Comment 6 Vijay Bellur 2015-09-10 01:56:18 UTC
REVIEW: http://review.gluster.org/11828 (tier/ctr: Lookup heal of cold tier during attach tier) posted (#8) for review on master by Dan Lambright (dlambrig)

Comment 7 Vijay Bellur 2015-10-10 17:42:11 UTC
COMMIT: http://review.gluster.org/11828 committed in master by Dan Lambright (dlambrig) 
------
commit f6618acd4f7642dab19445e35cf2c7fbc8244a5e
Author: Joseph Fernandes <josferna>
Date:   Tue Aug 4 20:38:06 2015 +0530

    tier/ctr: CTR DB named lookup heal of cold tier during attach tier
    
    Heal hardlink in the db for already existing data in the cold
    tier during attach tier. i.e during fix layout do lookup to files
    in the cold tier.
    
    CTR xlator on the  brick/server side does db update/insert of the hardlink on a namelookup.
    Currently the namedlookup is done synchronous to the fixlayout that is
    triggered by attach tier. This is not performant, adding more time to
    fixlayout. The performant approach is record the hardlinks on a compressed
    datastore and then do the namelookup asynchronously later, giving the ctr db
    eventual consistency
    
    Change-Id: I4ffc337fffe7d447804786851a9183a51b5044a9
    BUG: 1252586
    Signed-off-by: Joseph Fernandes <josferna>
    Reviewed-on: http://review.gluster.org/11828
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Dan Lambright <dlambrig>

Comment 8 Niels de Vos 2016-06-16 13:30:53 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user