Bug 1253103

Summary:	system's old disk records are not properly deleted when they change
Product:	[Retired] Beaker	Reporter:	Dan Callaghan <dcallagh>
Component:	general	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	21	CC:	dcallagh, dowang, mjia, rjoost
Target Milestone:	21.0	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-08-26 06:17:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Callaghan 2015-08-13 01:09:28 UTC

The latest version of beaker-system-scan has changed the value of the "model" column for disks in some cases (see bug 1247464 about that).

A system which previously had two disk rows:

Disks
Model 	Size 	Logical sector size 	Physical sector size
HP 73.4G ST373453LC 	73.41 GB / 68.37 GiB 	512 bytes 	512 bytes
HP 73.4G ST373453LC 	73.41 GB / 68.37 GiB 	512 bytes 	512 bytes 

was updated to have two new disks with different models, which should have been:

Disks
Model 	Size 	Logical sector size 	Physical sector size
ST373453LC 	73.41 GB / 68.37 GiB 	512 bytes 	512 bytes
ST373453LC 	73.41 GB / 68.37 GiB 	512 bytes 	512 bytes 

but instead we get:

Disks
Model 	Size 	Logical sector size 	Physical sector size
HP 73.4G ST373453LC 	73.41 GB / 68.37 GiB 	512 bytes 	512 bytes
ST373453LC 	73.41 GB / 68.37 GiB 	512 bytes 	512 bytes
ST373453LC 	73.41 GB / 68.37 GiB 	512 bytes 	512 bytes 

Beaker is failing to correctly delete the old rows when they are removed from the uploaded inventory data.

Comment 2 Dan Callaghan 2015-08-20 00:55:34 UTC

http://gerrit.beaker-project.org/4358

Comment 4 Dan Callaghan 2015-08-21 05:17:19 UTC

Steps to verify:
1. Run a hardware scan on a system with more than one disk (click Scan on Hardware Details tab).
2. Check that the correct disks are shown on the Hardware Details tab after the scan finishes successfully. There should be not extra disks shown.

Comment 8 Dan Callaghan 2015-08-26 06:17:16 UTC

Beaker 21.0 has been released.