Bug 1254301
Summary: | Upgrading torque will clobber the files in /etc/rc.d/init.d | ||
---|---|---|---|
Product: | [Fedora] Fedora EPEL | Reporter: | Kevin L. Esteb <kesteb> |
Component: | torque | Assignee: | David Brown <david.brown> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | el5 | CC: | david.brown, fotis, garrick, karlthered |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | torque-4.2.10-9.fc22 torque-4.2.10-9.fc23 torque-4.2.10-9.el5 torque-4.2.10-9.el7 torque-4.2.10-9.el6 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-02-22 20:49:19 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Kevin L. Esteb
2015-08-17 16:27:41 UTC
Its been my opinion (and I believe the rest of Fedora/EPEL) that /etc/rc.d/init.d files should not be changed by system administrators. If the init scripts do not allow for some feature to be passed through to the torque daemons that should be added as options to be overridden by /etc/sysconfig files. So, what changes did you make to the init.d files that you would like to see preserved in future releases? Thanks, - David Brown Personally I believe that if the local administrator makes changes to the init scripts they should be honored. I believe that is the Debian policy, but then this is Redhat. With that being said I added a PBS_ARGS to pbs_sched and pbs_mom so that I can define additional arguments on the command line. I also added a PBS_PORT to pbs_mom so I can define the port for momctl to communicate on. With those additions, I can then use the /etc/sysconfig files to set those variables. I don't use the default ports for torque. In 2.4, I could change /etc/service and it would be picked up. With 4.2, this doesn't seem to happen any more. Here is the sed script that I use in my configuration rpm for torque. # # fix some init.d files # if ! grep PBS_ARGS /etc/init.d/pbs_mom > /dev/nul ; then sed -i '/^PBS_HOME/a PBS_ARGS=""' /etc/init.d/pbs_mom sed -i '/^PBS_ARGS/a PBS_PORT=""' /etc/init.d/pbs_mom sed -i 's/momctl -s/momctl -s $PBS_PORT/g' /etc/init.d/pbs_mom sed -i 's/\$PBS_DAEMON \$args/$PBS_DAEMON $PBS_ARGS $args/g' /etc/init.d/pbs_mom fi # if ! grep PBS_ARGS /etc/init.d/pbs_sched > /dev/null ; then sed -i '/^PBS_HOME/a PBS_ARGS=""' /etc/init.d/pbs_sched sed -i 's/daemon \$PBS_DAEMON/daemon $PBS_DAEMON $PBS_ARGS/g' /etc/init.d/pbs_sched fi # # https://fedoraproject.org/wiki/EPEL:SysVInitScript For future reference. There looks like there's ways of setting args in the pbs_mom and pbs_sched files. args="-L /tmp/mylog.log" would go into into /etc/sysconfig/pbs_mom and it should get passed to the mom. However, if you specify a port as part of those arguments it wouldn't get passed to the momctl and the init script would fail... Let me take a look and do some testing. torque-4.2.10-9.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4465cb2604 torque-4.2.10-9.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a99d29fa05 torque-4.2.10-9.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-80daa121a4 torque-4.2.10-9.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-652d4f3054 torque-4.2.10-9.el5 has been submitted as an update to Fedora EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f2f3898eca torque-4.2.10-9.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f2f3898eca torque-4.2.10-9.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-652d4f3054 torque-4.2.10-9.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a99d29fa05 torque-4.2.10-9.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4465cb2604 torque-4.2.10-9.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-80daa121a4 torque-4.2.10-9.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. torque-4.2.10-9.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. torque-4.2.10-9.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. torque-4.2.10-9.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. torque-4.2.10-9.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |