Bug 1255452
| Summary: | fedora-easy-karma doesn't work after Bodhi 2 update | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Couret Charles-Antoine <renault> | ||||||
| Component: | fedora-easy-karma | Assignee: | Till Maas <opensource> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 22 | CC: | alick9188, ed.greshko, jpopelka, junk, klember, kparal, nonamedotc, opensource, robatino, sanjay.ankur, tflink, thofmann, watanabe.yu, williamjmorenor | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | fedora-easy-karma-0-0.26.20150921gitc932687a.fc22 fedora-easy-karma-0-0.26.20150921gitc932687a.fc23 fedora-easy-karma-0-0.26.20150921gitc932687a.fc21 fedora-easy-karma-0-0.26.20150921gitc932687a.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-10-03 21:15:17 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Couret Charles-Antoine
2015-08-20 15:30:09 UTC
Same with F23: fedora-easy-karma-0-0.25.20150508gitc8e437c0.fc23.noarch python-fedora-0.5.5-1.fc23.noarch Confirming. Created attachment 1066539 [details] patch to make fedora-easy-karma work with bodhi2 I'm waiting for some more information from the bodhi devs before considering it done but I have a patch which seems to be working for me. Test case rendering is currently disabled until a bodhi issue [1] is clarified and resolved. I've attached the patch to this bug - feedback is welcome [1] https://github.com/fedora-infra/bodhi/issues/270 Works for me too, thanks. When I run fedora-easy-karma today I noticed that it offers me to evaluate updates that I already evaluated (with '1', i.e. positive karma) yesterday. I'm using the patch from comment #3. I noticed that --no-skip-empty-comment option does not work. *** Bug 1259492 has been marked as a duplicate of this bug. *** *** Bug 1258079 has been marked as a duplicate of this bug. *** (In reply to Yu Watanabe from comment #6) > I noticed that --no-skip-empty-comment option does not work. Did that work before the upgrade to bodhi2? I don't see anything in the new bodhi2 stuff that would affect that functionality (In reply to Jiri Popelka from comment #5) > When I run fedora-easy-karma today I noticed that it offers me to evaluate > updates that I already evaluated (with '1', i.e. positive karma) yesterday. > I'm using the patch from comment #3. Thanks for mentioning this - I missed that part of the code but the next diff will get that working again Created attachment 1073344 [details]
updated patch to make f-e-k work with bodhi2
I've updated the patch to address some of the feedback and work around some issues. I'm not aware of any remaining issues and should be push-able to get f-e-k working without requiring patches.
Note that the retry logic in the bodhi client is currently not working. This won't affect the comment retry logic but I have been seeing some failures while pulling down update information. The issue for bodhi client retry logic has been filed upstream: https://github.com/fedora-infra/python-fedora/issues/144 (In reply to Tim Flink from comment #9) > (In reply to Yu Watanabe from comment #6) > > I noticed that --no-skip-empty-comment option does not work. > > Did that work before the upgrade to bodhi2? I don't see anything in the new > bodhi2 stuff that would affect that functionality Yes, it worked for me before the upgrade to bodhi2. (In reply to Tim Flink from comment #11) > Created attachment 1073344 [details] > updated patch to make f-e-k work with bodhi2 Works OK for me. fedora-easy-karma-0-0.26.20150921gitc932687a.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16437 fedora-easy-karma-0-0.26.20150921gitc932687a.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8194 fedora-easy-karma-0-0.26.20150921gitc932687a.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16439 fedora-easy-karma-0-0.26.20150921gitc932687a.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update fedora-easy-karma' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16437 fedora-easy-karma-0-0.26.20150921gitc932687a.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update fedora-easy-karma' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16438 fedora-easy-karma-0-0.26.20150921gitc932687a.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update fedora-easy-karma' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8194 fedora-easy-karma-0-0.26.20150921gitc932687a.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update fedora-easy-karma' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16439 fedora-easy-karma-0-0.26.20150921gitc932687a.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. fedora-easy-karma-0-0.26.20150921gitc932687a.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. fedora-easy-karma-0-0.26.20150921gitc932687a.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. fedora-easy-karma-0-0.26.20150921gitc932687a.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |