Bug 1255751
| Summary: | Valgrind is available on all Fedora architectures except s/390 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcin Juszkiewicz <mjuszkie> | ||||
| Component: | cscppc | Assignee: | Kamil Dudka <kdudka> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | kdudka, mjuszkie | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-08-21 16:43:11 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 467765, 922257, 1051573 | ||||||
| Attachments: |
|
||||||
This is intentional. From maintaining curl I learned that valgrind on secondary arches breaks too often. Instead of detecting bugs in curl, I was only debugging valgrind issues after update of gcc/glibc/valgrind. See the following bugs for examples:
bug #810992 - valgrind dies with ERROR = Iex.Binop: arg tys don't match op tys (OPENSSL_ppc64_probe)
bug #816175 - FTBFS: build failure on PPC, valgrind error in test 582
bug #886891 - FTBFS: lots of valgrind failures during self checks
OK, understand your reason. But please put notes about it in spec or git log. And specfile excludes one of primary architectures too. Sometimes failures of one packages lead to improvements in other ;) (In reply to Marcin Juszkiewicz from comment #2) > But please put notes about it in spec or git log. Sounds like a good idea! What about the following comment? # The test-suite runs automatically trough valgrind if valgrind is available # on the system. By not installing valgrind into mock's chroot, we disable # this feature for production builds on architectures where valgrind is known # to be less reliable, in order to avoid unnecessary build failures (see RHBZ # #810992, #816175, and #886891). Nevertheless developers are free to install # valgrind manually to improve test coverage on any architecture. %ifarch %{ix86} x86_64 BuildRequires: valgrind %endif Note there is exactly the same issue in cswrap, no need to report it separately. Sounds fine for me. |
Created attachment 1065594 [details] spec change Description of problem: cscppc has ifarch check for build dependency on valgrind. But it is not up-to-date as only s/390 lacks it nowadays. Version-Release number of selected component (if applicable): 1.2.0-4