Bug 1255751 - Valgrind is available on all Fedora architectures except s/390
Valgrind is available on all Fedora architectures except s/390
Product: Fedora
Classification: Fedora
Component: cscppc (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Kamil Dudka
Fedora Extras Quality Assurance
Depends On:
Blocks: ZedoraTracker ARM64/F-ExcludeArch-aarch64 F-ExcludeArch-ppc64le/PPC64LETracker
  Show dependency treegraph
Reported: 2015-08-21 08:59 EDT by Marcin Juszkiewicz
Modified: 2015-08-21 12:43 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2015-08-21 12:43:11 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
spec change (895 bytes, text/plain)
2015-08-21 08:59 EDT, Marcin Juszkiewicz
no flags Details

  None (edit)
Description Marcin Juszkiewicz 2015-08-21 08:59:11 EDT
Created attachment 1065594 [details]
spec change

Description of problem:

cscppc has ifarch check for build dependency on valgrind. But it is not up-to-date as only s/390 lacks it nowadays.

Version-Release number of selected component (if applicable):

Comment 1 Kamil Dudka 2015-08-21 09:35:21 EDT
This is intentional.  From maintaining curl I learned that valgrind on secondary arches breaks too often.  Instead of detecting bugs in curl, I was only debugging valgrind issues after update of gcc/glibc/valgrind.  See the following bugs for examples:

    bug #810992 - valgrind dies with ERROR = Iex.Binop: arg tys don't match op tys (OPENSSL_ppc64_probe)

    bug #816175 - FTBFS: build failure on PPC, valgrind error in test 582

    bug #886891 - FTBFS: lots of valgrind failures during self checks
Comment 2 Marcin Juszkiewicz 2015-08-21 10:38:21 EDT
OK, understand your reason. But please put notes about it in spec or git log.

And specfile excludes one of primary architectures too.

Sometimes failures of one packages lead to improvements in other ;)
Comment 3 Kamil Dudka 2015-08-21 11:02:51 EDT
(In reply to Marcin Juszkiewicz from comment #2)
> But please put notes about it in spec or git log.

Sounds like a good idea!  What about the following comment?

# The test-suite runs automatically trough valgrind if valgrind is available
# on the system.  By not installing valgrind into mock's chroot, we disable
# this feature for production builds on architectures where valgrind is known
# to be less reliable, in order to avoid unnecessary build failures (see RHBZ
# #810992, #816175, and #886891).  Nevertheless developers are free to install
# valgrind manually to improve test coverage on any architecture.
%ifarch %{ix86} x86_64
BuildRequires: valgrind

Note there is exactly the same issue in cswrap, no need to report it separately.
Comment 4 Marcin Juszkiewicz 2015-08-21 12:27:20 EDT
Sounds fine for me.

Note You need to log in before you can comment on or make changes to this bug.