Bug 1256255
| Summary: | Review Request: perl-DBIx-Class-OptimisticLocking - Optimistic locking support for DBIx::Class | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jplesnik, package-review |
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.02-2.fc23 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-09-18 19:01:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Emmanuel Seyman
2015-08-24 07:59:53 UTC
Source file is ok
Summary is ok
License is ok.
Description is ok
URL and Source0 are ok
All tests passed
FIX: Please add BR 'make'
Otherwise BRs are ok
$ rpm -qp --requires perl-DBIx-Class-OptimisticLocking-0.02-1.fc24.noarch.rpm | sort | uniq -c
1 perl(:MODULE_COMPAT_5.22.0)
1 perl(Carp)
1 perl(DBIx::Class) >= 0.08195
1 perl(List::Util)
1 perl(base)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -qp --provides perl-DBIx-Class-OptimisticLocking-0.02-1.fc24.noarch.rpm | sort | uniq -c
1 perl(DBIx::Class::OptimisticLocking) = 0.02
1 perl-DBIx-Class-OptimisticLocking = 0.02-1.fc24
Binary provides are Ok.
$ rpmlint perl-DBIx-Class-OptimisticLocking*
perl-DBIx-Class-OptimisticLocking.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-DBIx-Class-OptimisticLocking/LICENSE
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
Rpmlint is almost ok
TODO: Please report the wrong address to upstream.
Please correct all 'FIX' issues and consider fixing 'TODO' items
Otherwise, the package looks good.
Package APPROVED.
(In reply to Jitka Plesnikova from comment #1) > > FIX: Please add BR 'make' Done. > Rpmlint is almost ok > TODO: Please report the wrong address to upstream. Done. This is bug #106640 on rt.cpan.org . https://rt.cpan.org/Ticket/Display.html?id=106640 > Package APPROVED. Thank you, Jikta. Requesting SCM. New Package SCM Request ======================= Package Name: perl-DBIx-Class-OptimisticLocking Short Description: optimistic locking support for DBIx::Class Upstream URL: http://search.cpan.org/dist/DBIx-Class-OptimisticLocking/ Owners: eseyman Branches: f22 f23 InitialCC: perl-sig New Package SCM Request ======================= Package Name: perl-DBIx-Class-OptimisticLocking Short Description: Optimistic locking support for DBIx::Class Upstream URL: http://search.cpan.org/dist/DBIx-Class-OptimisticLocking/ Owners: eseyman Branches: f22 f23 InitialCC: perl-sig Git done (by process-git-requests). perl-DBIx-Class-OptimisticLocking-0.02-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14296 perl-DBIx-Class-OptimisticLocking-0.02-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |