Bug 1256255 - Review Request: perl-DBIx-Class-OptimisticLocking - Optimistic locking support for DBIx::Class
Summary: Review Request: perl-DBIx-Class-OptimisticLocking - Optimistic locking suppor...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-08-24 07:59 UTC by Emmanuel Seyman
Modified: 2015-09-18 19:01 UTC (History)
2 users (show)

Fixed In Version: 0.02-2.fc23
Clone Of:
Environment:
Last Closed: 2015-09-18 19:01:20 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2015-08-24 07:59:53 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Class-OptimisticLocking/perl-DBIx-Class-OptimisticLocking.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Class-OptimisticLocking/perl-DBIx-Class-OptimisticLocking-0.02-1.fc22.src.rpm
Description:
Optimistic locking is an alternative to using exclusive locks when you have
the possibility of concurrent, conflicting updates in your database.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2015-08-24 12:58:07 UTC
Source file is ok
Summary is ok
License is ok.
Description is ok
URL and Source0 are ok
All tests passed

FIX: Please add BR 'make'
Otherwise BRs are ok

$ rpm -qp --requires perl-DBIx-Class-OptimisticLocking-0.02-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Carp)
      1 perl(DBIx::Class) >= 0.08195
      1 perl(List::Util)
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

Binary requires are Ok.

$ rpm -qp --provides perl-DBIx-Class-OptimisticLocking-0.02-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(DBIx::Class::OptimisticLocking) = 0.02
      1 perl-DBIx-Class-OptimisticLocking = 0.02-1.fc24

Binary provides are Ok.

$ rpmlint perl-DBIx-Class-OptimisticLocking*
perl-DBIx-Class-OptimisticLocking.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-DBIx-Class-OptimisticLocking/LICENSE
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

Rpmlint is almost ok
TODO: Please report the wrong address to upstream.


Please correct all 'FIX' issues and consider fixing 'TODO' items
Otherwise, the package looks good.

Package APPROVED.

Comment 2 Emmanuel Seyman 2015-08-24 21:07:33 UTC
(In reply to Jitka Plesnikova from comment #1)
> 
> FIX: Please add BR 'make'

Done.

> Rpmlint is almost ok
> TODO: Please report the wrong address to upstream.

Done. This is bug #106640 on rt.cpan.org .
https://rt.cpan.org/Ticket/Display.html?id=106640

> Package APPROVED.

Thank you, Jikta. Requesting SCM.

New Package SCM Request
=======================
Package Name: perl-DBIx-Class-OptimisticLocking
Short Description: optimistic locking support for DBIx::Class
Upstream URL: http://search.cpan.org/dist/DBIx-Class-OptimisticLocking/
Owners: eseyman
Branches: f22 f23
InitialCC: perl-sig

Comment 3 Emmanuel Seyman 2015-08-24 21:10:26 UTC
New Package SCM Request
=======================
Package Name: perl-DBIx-Class-OptimisticLocking
Short Description: Optimistic locking support for DBIx::Class
Upstream URL: http://search.cpan.org/dist/DBIx-Class-OptimisticLocking/
Owners: eseyman
Branches: f22 f23
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2015-08-25 13:34:54 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2015-09-08 15:09:22 UTC
perl-DBIx-Class-OptimisticLocking-0.02-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14296

Comment 6 Fedora Update System 2015-09-18 19:01:18 UTC
perl-DBIx-Class-OptimisticLocking-0.02-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.