Bug 1256338 (kf5-akonadi)

Summary:	Review Request: kf5-akonadi - The Akonadi client libraries
Product:	[Fedora] Fedora	Reporter:	Daniel Vrátil <dvratil>
Component:	Package Review	Assignee:	Daniel Vrátil <me>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jgrulich, kevin, package-review
Target Milestone:	---	Flags:	jgrulich: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-04 14:46:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	656997

Description Daniel Vrátil 2015-08-24 11:45:10 UTC

Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-15.08.0-1.fc22.src.rpm
Description: <description here>
Fedora Account System Username: dvratil


This provides kf5-akonadi (the core client libraries) and kf5-akonadi-contact, kf5-akonadi-mime, kf5-akonadi-notes and kf5-socialtuils, which provide domain-specific libraries. There's also kf5-akonadi-calendar, but that's shipped by upstream as a separate tarball, hence separate specfile.

Comment 1 Jan Grulich 2015-08-31 21:04:57 UTC

1) Some files seem to be under BSD, LGPLv2+ and also under MIT/X11 license (according to licensecheck)
2) Missing gtk-update-icon-cache call in %postun and %posttrans for kf5-akonadi-contact 
3) Shouldn't you use %config for /etc/xdg/kdepimlibs-kioslave.categories?

Comment 2 Daniel Vrátil 2015-09-01 11:36:30 UTC

Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-15.08.0-2.fc22.src.rpm


* Tue Sep 01 2015 Daniel Vrátil <dvratil> - 15.08.0-2
- fix %%license
- add gtk-update-icon-cache to contact scriptlets
- add %%config for kdepimlibs-kioslave.categories

Comment 3 Jan Grulich 2015-09-01 11:56:01 UTC

Perfect, looks good now, package approved.

Comment 4 Daniel Vrátil 2015-09-01 14:55:51 UTC

New Package SCM Request
=======================
Package Name: kf5-akonadi
Short Description: The Akonadi Client Libraries
Upstream URL: https://projects.kde.org/projects/kde/kdepimlibs
Owners: dvratil group::kde-sig
Branches: f22 f23
InitialCC:

Comment 5 Gwyn Ciesla 2015-09-01 19:19:19 UTC

Please put group::kde-sig in InitialCC.

Git done (by process-git-requests).