Bug 1256338 (kf5-akonadi) - Review Request: kf5-akonadi - The Akonadi client libraries
Summary: Review Request: kf5-akonadi - The Akonadi client libraries
Keywords:
Status: CLOSED RAWHIDE
Alias: kf5-akonadi
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Daniel Vrátil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2015-08-24 11:45 UTC by Daniel Vrátil
Modified: 2015-12-04 14:46 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-12-04 14:46:44 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Daniel Vrátil 2015-08-24 11:45:10 UTC
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-15.08.0-1.fc22.src.rpm
Description: <description here>
Fedora Account System Username: dvratil


This provides kf5-akonadi (the core client libraries) and kf5-akonadi-contact, kf5-akonadi-mime, kf5-akonadi-notes and kf5-socialtuils, which provide domain-specific libraries. There's also kf5-akonadi-calendar, but that's shipped by upstream as a separate tarball, hence separate specfile.

Comment 1 Jan Grulich 2015-08-31 21:04:57 UTC
1) Some files seem to be under BSD, LGPLv2+ and also under MIT/X11 license (according to licensecheck)
2) Missing gtk-update-icon-cache call in %postun and %posttrans for kf5-akonadi-contact 
3) Shouldn't you use %config for /etc/xdg/kdepimlibs-kioslave.categories?

Comment 2 Daniel Vrátil 2015-09-01 11:36:30 UTC
Spec URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi.spec
SRPM URL: https://dvratil.fedorapeople.org/kdepim/review/kf5-akonadi-15.08.0-2.fc22.src.rpm


* Tue Sep 01 2015 Daniel Vrátil <dvratil> - 15.08.0-2
- fix %%license
- add gtk-update-icon-cache to contact scriptlets
- add %%config for kdepimlibs-kioslave.categories

Comment 3 Jan Grulich 2015-09-01 11:56:01 UTC
Perfect, looks good now, package approved.

Comment 4 Daniel Vrátil 2015-09-01 14:55:51 UTC
New Package SCM Request
=======================
Package Name: kf5-akonadi
Short Description: The Akonadi Client Libraries
Upstream URL: https://projects.kde.org/projects/kde/kdepimlibs
Owners: dvratil group::kde-sig
Branches: f22 f23
InitialCC:

Comment 5 Gwyn Ciesla 2015-09-01 19:19:19 UTC
Please put group::kde-sig in InitialCC.

Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.