Bug 1257268

Summary: N+1 Query when changing hostgroup from the "All Hosts" page
Product: Red Hat Satellite Reporter: Bryan Kearney <bkearney>
Component: PerformanceAssignee: Ohad Levy <ohadlevy>
Status: CLOSED ERRATA QA Contact: Stephen Benjamin <stbenjam>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.0.4CC: bbuckingham, brwillia, stbenjam, sthirugn
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/10589
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-27 08:55:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Bryan Kearney 2015-08-26 15:27:27 UTC
I believe there is a N+1 query when modifying a single host or multiple hosts from the "All Hosts" page of the Foreman. Changing a hostgroup from this page is taking ~5-8 minutes to complete depending on the number of hosts being modified.

Found by loading foreman-rake console
hg = Hostgroup.find_by_id(1)
h = Host.find_by_name("name of host")
h.save(:validate => false)

I've attached the specific query that I believe has the N+1. It is executed several times in this block of code which I think is the reason the host group change takes such a long time to complete.

Comment 1 Bryan Kearney 2015-08-26 15:27:28 UTC
Created from redmine issue http://projects.theforeman.org/issues/10589

Comment 5 Bryan Kearney 2015-08-26 18:03:40 UTC
Upstream bug component is Provisioning

Comment 6 Bryan Kearney 2015-08-26 18:43:26 UTC
Upstream bug component is Performance

Comment 7 Bryan Kearney 2015-08-31 06:04:02 UTC
Upstream bug assigned to tcaspy@redhat.com

Comment 8 Bryan Kearney 2015-09-09 14:04:43 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/10589 has been closed
Tom Caspy
Applied in changeset commit:88275be4587e98092095c501a8a7f58d7bcfaca4.

Comment 10 Stephen Benjamin 2016-03-24 19:25:05 UTC
Verified, as best as I can tell - there's not a number of hosts given for when the performance impact occurs.  however, I tried changing the host group on 10 hosts at once, and it was (nearly) instant.

Comment 14 errata-xmlrpc 2016-07-27 08:55:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.