Bug 1257268 - N+1 Query when changing hostgroup from the "All Hosts" page
Summary: N+1 Query when changing hostgroup from the "All Hosts" page
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Performance
Version: 6.0.4
Hardware: Unspecified
OS: Unspecified
unspecified
high vote
Target Milestone: Unspecified
Assignee: Ohad Levy
QA Contact: Stephen Benjamin
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-08-26 15:27 UTC by Bryan Kearney
Modified: 2019-09-26 17:37 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-27 08:55:04 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Foreman Issue Tracker 10589 None None None 2016-04-22 15:02:55 UTC
Red Hat Product Errata RHBA-2016:1500 normal SHIPPED_LIVE Red Hat Satellite 6.2 Base Libraries 2016-07-27 12:24:38 UTC

Description Bryan Kearney 2015-08-26 15:27:27 UTC
I believe there is a N+1 query when modifying a single host or multiple hosts from the "All Hosts" page of the Foreman. Changing a hostgroup from this page is taking ~5-8 minutes to complete depending on the number of hosts being modified.

Found by loading foreman-rake console
hg = Hostgroup.find_by_id(1)
h = Host.find_by_name("name of host")
h.hostgroup=hg
h.save(:validate => false)

I've attached the specific query that I believe has the N+1. It is executed several times in this block of code which I think is the reason the host group change takes such a long time to complete.

Comment 1 Bryan Kearney 2015-08-26 15:27:28 UTC
Created from redmine issue http://projects.theforeman.org/issues/10589

Comment 5 Bryan Kearney 2015-08-26 18:03:40 UTC
Upstream bug component is Provisioning

Comment 6 Bryan Kearney 2015-08-26 18:43:26 UTC
Upstream bug component is Performance

Comment 7 Bryan Kearney 2015-08-31 06:04:02 UTC
Upstream bug assigned to tcaspy@redhat.com

Comment 8 Bryan Kearney 2015-09-09 14:04:43 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/10589 has been closed
-------------
Tom Caspy
Applied in changeset commit:88275be4587e98092095c501a8a7f58d7bcfaca4.

Comment 10 Stephen Benjamin 2016-03-24 19:25:05 UTC
Verified, as best as I can tell - there's not a number of hosts given for when the performance impact occurs.  however, I tried changing the host group on 10 hosts at once, and it was (nearly) instant.

Comment 14 errata-xmlrpc 2016-07-27 08:55:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1500


Note You need to log in before you can comment on or make changes to this bug.