Bug 1258343
| Summary: | inadyn-mt packaging improvements | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||
| Component: | inadyn-mt | Assignee: | Jochen Schmitt <jochen> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | jochen, mike | ||||
| Target Milestone: | --- | Keywords: | Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | inadyn-mt-2.24.47-1.fc23 inadyn-mt-2.24.47-1.fc22 inadyn-mt-2.24.47-1.fc21 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-10-03 17:56:19 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Ping? There are some quite important fixes included in this one. Unless I hear back soon, I'm going to push this so that it makes it to F-23. Since the primary maintainer is MIA I will comment. The changes look good, however, the systemd service file needs "Type=forking". I can apply your changes if you wish with the one correction. (In reply to Michael Cronenworth from comment #2) > the systemd service file needs "Type=forking". I disagree. The daemon does not actually fork, unless given the --background argument, which is not given in the service file nor in the default config. Adding Type=forking makes for example "systemctl start inadyn.service" to never return. Sorry, my comment was based on my old config file. After some investigation, back in 2012, the "background" option was removed from the default config file. Mine still had it. I'll apply your changes as-is. inadyn-mt-2.24.47-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16047 inadyn-mt-2.24.47-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16048 inadyn-mt-2.24.47-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16049 inadyn-mt-2.24.47-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update inadyn-mt'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16047 inadyn-mt-2.24.47-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update inadyn-mt'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16049 inadyn-mt-2.24.47-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update inadyn-mt'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16048 inadyn-mt-2.24.47-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. inadyn-mt-2.24.47-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. inadyn-mt-2.24.47-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1068510 [details] Packaging fixes Patch with the following packaging improvements attached, let met know if you'd like me to push and build this for F-23+: - Update to 2.24.47 - Run as dedicated inadyn user/group - Use /var/cache/inadyn-mt for caching - Restrict read access to config file (contains auth data) - Avoid duplicate syslog messages - Fix systemd service type