Bug 1258343 - inadyn-mt packaging improvements
Summary: inadyn-mt packaging improvements
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: inadyn-mt
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jochen Schmitt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-08-31 06:50 UTC by Ville Skyttä
Modified: 2015-10-03 21:52 UTC (History)
2 users (show)

Fixed In Version: inadyn-mt-2.24.47-1.fc23 inadyn-mt-2.24.47-1.fc22 inadyn-mt-2.24.47-1.fc21
Clone Of:
Environment:
Last Closed: 2015-10-03 17:56:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Packaging fixes (2.69 KB, patch)
2015-08-31 06:50 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2015-08-31 06:50:35 UTC
Created attachment 1068510 [details]
Packaging fixes

Patch with the following packaging improvements attached, let met know if you'd like me to push and build this for F-23+:

- Update to 2.24.47
- Run as dedicated inadyn user/group
- Use /var/cache/inadyn-mt for caching
- Restrict read access to config file (contains auth data)
- Avoid duplicate syslog messages
- Fix systemd service type

Comment 1 Ville Skyttä 2015-09-16 06:29:36 UTC
Ping? There are some quite important fixes included in this one. Unless I hear back soon, I'm going to push this so that it makes it to F-23.

Comment 2 Michael Cronenworth 2015-09-16 13:53:42 UTC
Since the primary maintainer is MIA I will comment.

The changes look good, however, the systemd service file needs "Type=forking". I can apply your changes if you wish with the one correction.

Comment 3 Ville Skyttä 2015-09-16 14:13:32 UTC
(In reply to Michael Cronenworth from comment #2)
> the systemd service file needs "Type=forking".

I disagree. The daemon does not actually fork, unless given the --background argument, which is not given in the service file nor in the default config. Adding Type=forking makes for example "systemctl start inadyn.service" to never return.

Comment 4 Michael Cronenworth 2015-09-16 14:34:17 UTC
Sorry, my comment was based on my old config file. After some investigation, back in 2012, the "background" option was removed from the default config file. Mine still had it. I'll apply your changes as-is.

Comment 5 Fedora Update System 2015-09-16 19:00:06 UTC
inadyn-mt-2.24.47-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16047

Comment 6 Fedora Update System 2015-09-16 19:02:11 UTC
inadyn-mt-2.24.47-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16048

Comment 7 Fedora Update System 2015-09-16 19:03:50 UTC
inadyn-mt-2.24.47-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16049

Comment 8 Fedora Update System 2015-09-17 21:30:35 UTC
inadyn-mt-2.24.47-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update inadyn-mt'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16047

Comment 9 Fedora Update System 2015-09-18 05:21:27 UTC
inadyn-mt-2.24.47-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update inadyn-mt'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16049

Comment 10 Fedora Update System 2015-09-18 16:24:56 UTC
inadyn-mt-2.24.47-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update inadyn-mt'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16048

Comment 11 Fedora Update System 2015-10-03 17:56:16 UTC
inadyn-mt-2.24.47-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2015-10-03 21:17:10 UTC
inadyn-mt-2.24.47-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2015-10-03 21:52:51 UTC
inadyn-mt-2.24.47-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.