Bug 1258406

Summary:	libgfapi : pending - porting log messages to a new framework
Product:	[Community] GlusterFS	Reporter:	Manikandan <mselvaga>
Component:	logging	Assignee:	Manikandan <mselvaga>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.7.3	CC:	annair, bugs, gluster-bugs, mselvaga, sasundar, smohan
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.5	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1242268	Environment:
Last Closed:	2015-10-14 10:30:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1242268
Bug Blocks:	1241957, 1252807

Description Manikandan 2015-08-31 10:02:48 UTC

+++ This bug was initially created as a clone of Bug #1242268 +++

Description of problem:
------------------------
There are few gf_log instance under api directory in the source code base of glusterfs. These should be ported to new logging framework

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHGS 3.1 Nightly Build ( glusterfs-3.7.1-8.el6rhs )

Instances of gf_log
-------------------
[satheesaran@dhcppc1 api]$ grep -r "gf_log " * -A1
src/glfs-fops.c:        gf_log (THIS->name, GF_LOG_DEBUG,
src/glfs-fops.c-                "Upcall gfapi callback is called");
--
src/glfs-fops.c:        gf_log (THIS->name, GF_LOG_TRACE, "Upcall gfapi gfid = %s"
src/glfs-fops.c-                "ret = %d", (char *)(upcall_data->gfid), ret);
--
src/glfs-fops.c:                gf_log (THIS->name, GF_LOG_ERROR, "Upcall entry allocation"
src/glfs-fops.c-                        "failed.");
--
src/glfs-handleops.c:                        gf_log (subvol->name, GF_LOG_WARNING,
src/glfs-handleops.c-                                "handle creation of %s failed: %s",

Comment 1 Anand Avati 2015-08-31 10:17:07 UTC

REVIEW: http://review.gluster.org/12063 (libgfapi : port missing gf_log's to gf_msg) posted (#1) for review on release-3.7 by Manikandan Selvaganesh (mselvaga)

Comment 2 Anand Avati 2015-09-01 05:30:53 UTC

COMMIT: http://review.gluster.org/12063 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit 93519aed0f32570bd6fb8e0113f76a75545ab804
Author: Manikandan Selvaganesh <mselvaga>
Date:   Wed Aug 12 14:46:29 2015 +0530

    libgfapi : port missing gf_log's to gf_msg
    
            Backport of http://review.gluster.org/#/c/11891/
    
    Cherry-picked from commit 1e0644031c7ac0fa28f0912e951a9238f7bbe8ab
    > Change-Id: I0c5320c09b4a5ff1e9df61a86ac7bd47c1bb1bbb
    > BUG: 1252807
    > Signed-off-by: Manikandan Selvaganesh <mselvaga>
    > Reviewed-on: http://review.gluster.org/11891
    > Tested-by: NetBSD Build System <jenkins.org>
    > Reviewed-by: Raghavendra Talur <rtalur>
    > Reviewed-by: jiffin tony Thottan <jthottan>
    > Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    > Reviewed-by: Raghavendra G <rgowdapp>
    
    Change-Id: I0c5320c09b4a5ff1e9df61a86ac7bd47c1bb1bbb
    BUG: 1258406
    Signed-off-by: Manikandan Selvaganesh <mselvaga>
    Reviewed-on: http://review.gluster.org/12063
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Pranith Kumar K 2015-10-14 10:30:28 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.7.5, please open a new bug report.

glusterfs-glusterfs-3.7.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-users/2015-October/023968.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Pranith Kumar K 2015-10-14 10:38:51 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.5, please open a new bug report.

glusterfs-3.7.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-users/2015-October/023968.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user