Bug 1258791

Summary:	sushi does not preview non utf8 text files
Product:	Red Hat Enterprise Linux 7	Reporter:	Martin Simon <msimon>
Component:	sushi	Assignee:	Florian Müllner <fmuellner>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.2	CC:	mclasen, tpelka
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	sushi-3.21.91-1.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-01 22:59:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Simon 2015-09-01 10:06:27 UTC

Description of problem:
I've tried to open some text files and only utf-8 can be displayed. I've tried iso8859-1, iso8859-15, utf-8, utf-16, cp1250 and cp1252.

Version-Release number of selected component (if applicable):
sushi-3.12.0-3.el7.x86_64
nautilus-3.14.3-3.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Select any text file which is not encoded in utf-8
2. Hit space bar

Actual results:
A spinner in sushi window is cycling, and cycling, ...

Expected results:
sushi windows with a scrollable context of sample non utf-8 text file

Additional info:
I've tested the same sample text file with special characters converted to different encodings via iconv

Comment 1 Matthias Clasen 2015-09-18 18:34:10 UTC

This works with upstream sushi, the fix is in

commit 898d8f23538a6b62f73c032be662f53487809e79
Author: Cosimo Cecchi <cosimoc>
Date:   Thu Jun 25 15:07:53 2015 -0700

    text-loader: use GtkSourceFileLoader
    
    Instead of our homebrew implementation, since GtkSourceFileLoader deals
    with non-UTF8 text as well.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704245

Comment 7 errata-xmlrpc 2017-08-01 22:59:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:2151