Bug 1261080

Summary: no talloc stackframe at ../source3/libsmb/clifsinfo.c:497, leaking memory
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: sambaAssignee: Guenther Deschner <gdeschner>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 21CC: abokovoy, asn, gdeschner, jlayton, lmohanty, madam, sbose, ssorce
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: samba-4.1.20-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1261107 (view as bug list) Environment:
Last Closed: 2015-10-05 22:52:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1261107    
Attachments:
Description Flags
diff -up samba-4.1.17/source3/libsmb/libsmb_stat.c samba-4.2.3/source3/libsmb/ none

Description Remi Collet 2015-09-08 14:23:42 UTC 
Created attachment 1071381 [details]
diff -up samba-4.1.17/source3/libsmb/libsmb_stat.c samba-4.2.3/source3/libsmb/

With libsmbclient-4.1.17-1.fc21

Description of problem:
I work in a libsmbclient wrapper for PHP
https://github.com/eduardok/libsmbclient-php

Running the test suite I got this message.
no talloc stackframe at ../source3/libsmb/clifsinfo.c:497, leaking memory

This is raised when calling smbc_statvfs or smbc_fstatvfs.

Diggin in the libsmb source, in source3/libsmb/clifsinfo.c a call to talloc_tos is done, but no call to talloc_stackframe.

Diffing various version, I think this is fixed in 4.2 / 4.3
Comment 1 Remi Collet 2015-09-08 14:27:04 UTC 
I think RHEL-7 version is also affected.
Comment 2 Remi Collet 2015-09-08 14:52:30 UTC 
I confirm a rebuild of the F21 .src.rpm with the attached patch fix this issue.
Comment 3 Remi Collet 2015-09-09 09:44:11 UTC 
Upstream commit:
https://git.samba.org/?p=samba.git;a=commit;h=32cbbed979b931eeb5127629248a94d7e6f3fcfb
Comment 4 Fedora Update System 2015-09-14 19:59:10 UTC 
samba-4.1.20-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15862
Comment 5 Remi Collet 2015-09-15 06:56:31 UTC 
Thanks for the quick update
Comment 6 Fedora Update System 2015-09-15 22:54:31 UTC 
libtalloc-2.1.2-1.fc21, samba-4.1.20-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update samba libtalloc'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15862
Comment 7 Fedora Update System 2015-10-05 22:52:38 UTC 
libtalloc-2.1.2-1.fc21, samba-4.1.20-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.