Bug 1261449

Summary: Met error when docker build's source code's format is 'git://github.com/<repo>.git'
Product: OpenShift Container Platform Reporter: zhou ying <yinzhou>
Component: BuildAssignee: Michal Fojtik <mfojtik>
Status: CLOSED ERRATA QA Contact: Wenjing Zheng <wzheng>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.0.0CC: aos-bugs, bparees, pruan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openshift-3.0.1.900-0.git.251.56c53fd.el7ose.x86_64 Doc Type: Bug Fix
Doc Text:
Cause: Git URI parsing did not handle git:// style URIs. Consequence: Builds that used git:// style GIT URIs would fail. Fix: GIT URI parsing has been updated to account for git:// style URIs. Result: Builds using git:// style GIT URIs will not work properly.
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-22 19:52:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description zhou ying 2015-09-09 11:03:19 UTC
Description of problem:
When source code's format is 'git://' to create a docker build app, met error, and build failed.
        "source": {
          "type": "Git",
          "git": {
            "uri": "git://github.com/openshift/ruby-hello-world.git"
          }
        },


Version-Release number of selected component (if applicable):
oc v3.0.1.900-185-g2f7757a
kubernetes v1.1.0-alpha.0-1605-g44c91b1

How reproducible:
Always

Steps to Reproduce:
1. Create a project;
2. Use command to create a docker build:
   `oc  new-app application-template-dockerbuild.json`
3. Check build status and build log;

Actual results:
The build always failed, the logs like this:
[zhouy@zhouy Work]$ oc get build
NAME                  TYPE      STATUS    POD
ruby-sample-build-1   Docker    Failed    ruby-sample-build-1-build
[zhouy@zhouy Work]$ oc build-logs ruby-sample-build-1
F0909 05:52:10.542511       1 builder.go:47] Build error: dial tcp: missing port in address github.com

Expected results:
The build should successfully.

Additional info:
When use origin env , the docker build can successfully.

Comment 2 Ben Parees 2015-09-09 16:09:31 UTC
fixed here: https://github.com/openshift/origin/pull/4573

Comment 4 zhou ying 2015-09-11 08:22:54 UTC
Confirmed on :
oc v3.0.1.900-185-g2f7757a
kubernetes v1.1.0-alpha.0-1605-g44c91b

The bug fixed, and works well:
[root@dhcp-136-93 ~]# oc get build
NAME                  TYPE      STATUS     POD
ruby-sample-build-1   Docker    Complete   ruby-sample-build-1-build

Comment 6 errata-xmlrpc 2015-09-22 19:52:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2015:1835