Bug 1261548

Summary:	oc run --attach gives error: "cannot attach to DeploymentConfig: not implemented"
Product:	OKD	Reporter:	Jordan Liggitt <jliggitt>
Component:	oc	Assignee:	Fabiano Franz <ffranz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Wei Sun <wsun>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.x	CC:	aos-bugs, dmcphers, mmccomas, yapei
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-23 21:16:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jordan Liggitt 2015-09-09 15:27:55 UTC

Extracted from https://bugzilla.redhat.com/show_bug.cgi?id=1258390

When --attach option is carried in 'oc run', there is error info indicating "not implemented"
$ oc run nginx --image=nginx --attach=true. 
error: cannot attach to DeploymentConfig: not implemented

Comment 1 Jordan Liggitt 2015-09-09 16:12:41 UTC

OpenShift overrides the "run" command generator to create a DeploymentConfig instead of a replication controller. We need to also inject handling of `--attach` for that object, since the core command doesn't know what to do with it

Comment 2 openshift-github-bot 2015-10-29 05:16:21 UTC

Commit pushed to master at https://github.com/openshift/origin

https://github.com/openshift/origin/commit/65775d3955417cf81258df83b10a603f068c6b3c
Bug 1261548 - oc run --attach support for DeploymentConfig

Comment 3 Yadan Pei 2015-10-30 03:33:08 UTC

Verified on devenv-fedora_2595

oc v1.0.7-32-gd17e473
kubernetes v1.2.0-alpha.1-1107-g4c8e6f4

$ oc run hello-openshift --image=yapei/hello-openshift --attach=true
Waiting for pod yapei-test/hello-openshift-1-isso6 to be running, status is Pending, pod ready: false
Waiting for pod yapei-test/hello-openshift-1-isso6 to be running, status is Pending, pod ready: false
Waiting for pod yapei-test/hello-openshift-1-isso6 to be running, status is Pending, pod ready: false
Waiting for pod yapei-test/hello-openshift-1-isso6 to be running, status is Pending, pod ready: false
Waiting for pod yapei-test/hello-openshift-1-isso6 to be running, status is Pending, pod ready: false
Waiting for pod yapei-test/hello-openshift-1-isso6 to be running, status is Pending, pod ready: false
Started, serving at 8080

it works as expected