Bug 1265901

Summary: NullPointerException with kie-config-cli.sh after migration from 6.1.0 to 6.1.2
Product: [Retired] JBoss BRMS Platform 6 Reporter: Toshiya Kobayashi <tkobayas>
Component: Business CentralAssignee: manstis
Status: CLOSED EOL QA Contact: Jiri Locker <jlocker>
Severity: high Docs Contact:
Priority: high    
Version: 6.1.0CC: agiertli, kverlaen
Target Milestone: ER5   
Target Release: 6.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-27 19:40:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
niogit610.zip none

Description Toshiya Kobayashi 2015-09-24 06:49:41 UTC
Created attachment 1076364 [details]
niogit610.zip

Description of problem:

When you migrate from 6.1.0 to 6.1.2 (a.k.a. 6.1 Update 2), kie-config-cli.sh "add-group-repo" (and add-group-org-unit) throws NullPointerException against a repository which:

- was created in 6.1.0
and
- has no role in "security:roles"

===============================
>>Please enter command (type help to see available commands): 
list-repo
Result:
Currently available repositories: 
	Repository repository1
	 scheme: git
	 uri: git://repository1
	 environment: {username=brmsAdmin, scheme=git, security:roles=[], origin=ssh://brmsAdmin@localhost:8001/repository1, password=****}
	 groups: []

>>>>>>>>>>>>>>>>>>>>>>>>>>>
>>Please enter command (type help to see available commands): 
add-group-repo
>>Repository alias:repository1
>>Security groups (comma separated list):role1
Unhandled exception caught while executing command add-group-repo error: null
java.lang.NullPointerException
	at org.guvnor.structure.backend.repositories.RepositoryServiceImpl.addGroup(RepositoryServiceImpl.java:230)
	at org.guvnor.structure.backend.repositories.RepositoryServiceImpl$Proxy$_$$_WeldClientProxy.addGroup(RepositoryServiceImpl$Proxy$_$$_WeldClientProxy.java)
	at org.kie.config.cli.command.impl.AddGroupToRepositoryCliCommand.execute(AddGroupToRepositoryCliCommand.java:39)
	at org.kie.config.cli.CmdMain.main(CmdMain.java:97)
================================


Steps to Reproduce:
1. Download attached niogit610.zip (pure '.niogit' after BRMS 6.1.0 boot)
2. Copy the '.niogit' directory to BRMS 6.1.2. (This step simulates that you apply the update patch 2 to 6.1.0)
3. Start BRMS 6.1.2
4. Run kie-config-cli.sh (Make sure that the update patch is also applied to supplementary-tools)
 > add-group-repo
 >>Repository alias:repository1
 >>Security groups (comma separated list):role1

Actual results:

It throws NullPointerException

Expected results:

'role1' is added to repository1.

Comment 1 Toshiya Kobayashi 2015-09-24 06:52:12 UTC
I see that BackwardCompatibleUtil should take care of "security:roles". But if "security:roles" was an empty list, it will not be converted to "security:groups".

https://github.com/droolsjbpm/guvnor/blob/6.2.x/guvnor-structure/guvnor-structure-backend/src/main/java/org/guvnor/structure/backend/backcompat/BackwardCompatibleUtil.java#L28

Comment 5 Pavel Kralik 2015-11-06 16:39:12 UTC
BPMS 6.2.0.ER5