Created attachment 1076364 [details] niogit610.zip Description of problem: When you migrate from 6.1.0 to 6.1.2 (a.k.a. 6.1 Update 2), kie-config-cli.sh "add-group-repo" (and add-group-org-unit) throws NullPointerException against a repository which: - was created in 6.1.0 and - has no role in "security:roles" =============================== >>Please enter command (type help to see available commands): list-repo Result: Currently available repositories: Repository repository1 scheme: git uri: git://repository1 environment: {username=brmsAdmin, scheme=git, security:roles=[], origin=ssh://brmsAdmin@localhost:8001/repository1, password=****} groups: [] >>>>>>>>>>>>>>>>>>>>>>>>>>> >>Please enter command (type help to see available commands): add-group-repo >>Repository alias:repository1 >>Security groups (comma separated list):role1 Unhandled exception caught while executing command add-group-repo error: null java.lang.NullPointerException at org.guvnor.structure.backend.repositories.RepositoryServiceImpl.addGroup(RepositoryServiceImpl.java:230) at org.guvnor.structure.backend.repositories.RepositoryServiceImpl$Proxy$_$$_WeldClientProxy.addGroup(RepositoryServiceImpl$Proxy$_$$_WeldClientProxy.java) at org.kie.config.cli.command.impl.AddGroupToRepositoryCliCommand.execute(AddGroupToRepositoryCliCommand.java:39) at org.kie.config.cli.CmdMain.main(CmdMain.java:97) ================================ Steps to Reproduce: 1. Download attached niogit610.zip (pure '.niogit' after BRMS 6.1.0 boot) 2. Copy the '.niogit' directory to BRMS 6.1.2. (This step simulates that you apply the update patch 2 to 6.1.0) 3. Start BRMS 6.1.2 4. Run kie-config-cli.sh (Make sure that the update patch is also applied to supplementary-tools) > add-group-repo >>Repository alias:repository1 >>Security groups (comma separated list):role1 Actual results: It throws NullPointerException Expected results: 'role1' is added to repository1.
I see that BackwardCompatibleUtil should take care of "security:roles". But if "security:roles" was an empty list, it will not be converted to "security:groups". https://github.com/droolsjbpm/guvnor/blob/6.2.x/guvnor-structure/guvnor-structure-backend/src/main/java/org/guvnor/structure/backend/backcompat/BackwardCompatibleUtil.java#L28
BPMS 6.2.0.ER5