Bug 1266712
Summary: | trojita: FTBFS in rawhide | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Raphael Groner <projects.rg> |
Component: | trojita | Assignee: | Raphael Groner <projects.rg> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | rawhide | CC: | kde-sig, kevin, projects.rg |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://apps.fedoraproject.org/koschei/package/trojita | ||
Whiteboard: | |||
Fixed In Version: | trojita-0.5-8.fc23 trojita-0.5-8.fc22 trojita-0.5a-2.20151216gitefa30f3.fc23 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-12-25 00:25:59 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1250005, 1254125, 1256476, 1257267, 1257356 |
Description
Raphael Groner
2015-09-26 19:27:56 UTC
error: definition of implicitly-declared 'Gui::AbookAddressbook::AbookAddressbook()' AbookAddressbook::AbookAddressbook(): m_updateTimer(0) This appears to be a bug in upstream Trojita. What the error message means is that if you're going to implement the default constructor with a function (method) definition, e.g.: AbookAddressbook::AbookAddressbook(): m_updateTimer(0) { … } you need to explicitly declare it: AbookAddressbook(); in your class definition. If you don't declare it, a default AbookAddressbook() constructor is inserted, but also with the default definition. I am surprised g++ ever let you get away with such an error. Hi Kevin, thanks for your explanation, I'm already aware of that cause but did not find any spare time to prepare a patch although this FTBFS should be fixed ASAP cause of F23 final freeze is going to happen soon. No idea why g++ did not fail earlier. I would be happy if someone can suggest a patch to let me send it to upstream. So I looked at the code, and I'm starting to think it is actually a g++ issue after all. I see this in the header file: namespace Gui { /** @short A generic local adressbook interface*/ class AbookAddressbook : public QObject, public AbstractAddressbook { Q_OBJECT public: AbookAddressbook(); … so this is explicitly declared, why does g++ think it is implicitly declared? Kevin, this is no bug of g++. There's a missing inclusion of QObject header, you seem to concentrate at the error of cpp file only, but the parsing of header is failing at first. Though after have fixed that header inclusion, I stumble upon other errors. raphgro's trojita-0.5-8.fc24 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=689647 trojita-0.5-8.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-0c610f1807 trojita-0.5-8.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d40188ca10 trojita-0.5-8.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update trojita' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d40188ca10 trojita-0.5-8.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update trojita' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-0c610f1807 trojita-0.5-8.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. trojita-0.5-8.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. trojita-0.5a-2.20151216gitefa30f3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update trojita' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-afb9844b79 trojita-0.5a-2.20151216gitefa30f3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |