Bug 126723

Summary:	issues with the gimp desktop entry
Product:	[Fedora] Fedora	Reporter:	Ville Skyttä <scop>
Component:	gimp	Assignee:	Nils Philippsen <nphilipp>
Status:	CLOSED RAWHIDE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2	CC:	snickell
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2004-11-23 16:46:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ville Skyttä 2004-06-25 11:41:46 UTC

gimp-2.0.2-1.fc2.2's gimp.desktop has some issues:

- Ugly legacy encodings, and lacks the Encoding=Legacy-Mixed key.
- Lacks GenericName (should be "Image Editor" if Name is
  "GIMP Image Editor"; see GNOME HIG).
- Non-GNOME HIG compliant Comment fields
- Terminal=0 is deprecated, should be Terminal=false
- Missing trailing semicolon in Categories
- No MimeType definitions, adding those would allow "Open with GIMP 
  Image Editor" for images at least in Konqueror, perhaps GNOME too.

To me it looks like it would be a better strategy to use
desktop-file-install to install and use the upstream .desktop file,
and apply the GenericName, Name and MimeType changes there instead of
shipping an external, somewhat outdated one.

Comment 1 Nils Philippsen 2004-06-26 08:19:21 UTC

Seth, you made the change to "GIMP Image Editor" in the old desktop
file -- I see some small problems:

If I use the shipped desktop file (which I'm inclined to do) and
change the Name, all the translations are gone. I could patch the
generated files, but then the translations would be wrong. I could
just not change the shipped desktop file, but then it would be listed
as "The GIMP" in the menu. If I change the desktop file, we would
either have to get the change accepted upstream or update myriads of
translations and maintain this patch indefinitely.

What's your opinion on how we should handle this?

Comment 2 Nils Philippsen 2004-08-02 14:17:25 UTC

Current gimp packages (in FC2-updates-testing and Rawhide/devel) use
the files as shipped in the tarball, could you check whether the
issues still persist? Thanks.

Comment 3 Ville Skyttä 2004-08-05 21:56:10 UTC

Skimming the desktop entry in gimp-2.0.3-2: it looks quite a bit
better, and the remaining issues are upstream ones, and not that big
deal.  Namely:
- GenericName missing (should be "<Name> Image Editor" or somesuch, 
  properly i18n'd, see GNOME HIG development version)
- Still no MimeType entries (see initial comment in this bug)

As far as I'm concerned, this can be closed.  Feel free to report the
remaining bits upstream if you feel like it :)

Comment 4 Nils Philippsen 2004-11-23 16:46:09 UTC

gimp-2.2-pre has GenericName and MimeType