Bug 1269796

Summary:	deprecated config values may brake the upgrade process
Product:	[oVirt] ovirt-engine	Reporter:	Eli Mesika <emesika>
Component:	Backend.Core	Assignee:	Eli Mesika <emesika>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jiri Belka <jbelka>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.6.0	CC:	bugs, ecohen, gklein, lsurette, masayag, oourfali, rbalakri, Rhev-m-bugs, yeylon
Target Milestone:	ovirt-3.6.1	Flags:	ylavi: ovirt-3.6.z? rule-engine: planning_ack? masayag: devel_ack+ pstehlik: testing_ack+
Target Release:	3.6.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-01-19 15:37:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eli Mesika 2015-10-08 08:55:29 UTC

Description of problem:

Up to now when a config entry was deprecated, we had to remove it in the
pre-upgrade step calling fn_db_delete_config_value from 0000_config.sql.

This may be problematic if a reference to the deleted entry exists in one
of the upgrade scripts, in such case the entry will be removed in the
pre-upgrade step and then the upgrade script referring this key will fail
and cause all the upgrade process to fail.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Attempt to delete a config key that exists in one of the upgrade scripts
2. run upgrade

Actual results:
Upgrade process fails on the script that refers the removed config key 

Expected results:
Upgrade scripts succeeds 

Additional info:
all deprecated config entries should be moved to an upgrade script
resolving this issue and adding additional benefit of executing all this
mass removals only once instead doing that again and again on each
upgrade.

Comment 1 Red Hat Bugzilla Rules Engine 2015-10-19 10:54:46 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 Yaniv Lavi 2015-10-29 12:38:14 UTC

In oVirt testing is done on single release by default. Therefore I'm removing the 4.0 flag. If you think this bug must be tested in 4.0 as well, please re-add the flag. Please note we might not have testing resources to handle the 4.0 clone.

Comment 3 Jiri Belka 2016-01-14 13:38:07 UTC

ok, rhevm-dbscripts-3.6.2.5-0.1.el6.noarch

no 'fn_db_delete_config*' in pre_upgrade scripts.