Bug 1271090

Summary: Review Request: php-ruflin-elastica - Elastica is a PHP client for elasticsearch
Product: [Fedora] Fedora Reporter: Michael Cronenworth <mike>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-14 17:21:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Cronenworth 2015-10-13 07:19:01 UTC 
Spec URL: http://michael.cronenworth.com/RPMS/php-ruflin-elastica.spec
SRPM URL: http://michael.cronenworth.com/RPMS/php-ruflin-elastica-2.3.0-1.fc22.src.rpm
Description: Elastica is a PHP client for elasticsearch: http://elastica.io/
Fedora Account System Username: mooninite
Comment 1 Remi Collet 2015-10-13 08:22:05 UTC 
From PHP Guidelines:
   A PSR-4 [2] compliant library would put its PHP files in
   /usr/share/php/<Vendor Name> in a PSR-0 compliant tree.

And used namespace is Elastica which should be the top level.
Comment 2 Remi Collet 2015-10-13 08:24:11 UTC 
psr/log is required (see composer.json), and use "composer"  dependencies.
Comment 3 Remi Collet 2015-10-13 08:27:01 UTC 
And it seems a good pratice to include autoload for dependencies
(ok psr/Log don't have one, but quite easy to ask its maintainer to add it)
Comment 4 Michael Cronenworth 2016-12-14 17:21:57 UTC 
With Fedora's change on bundled libraries I am not going to pursue this review.