Bug 1271090 - Review Request: php-ruflin-elastica - Elastica is a PHP client for elasticsearch
Review Request: php-ruflin-elastica - Elastica is a PHP client for elasticsearch
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2015-10-13 03:19 EDT by Michael Cronenworth
Modified: 2016-12-14 12:21 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-12-14 12:21:57 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Michael Cronenworth 2015-10-13 03:19:01 EDT
Spec URL: http://michael.cronenworth.com/RPMS/php-ruflin-elastica.spec
SRPM URL: http://michael.cronenworth.com/RPMS/php-ruflin-elastica-2.3.0-1.fc22.src.rpm
Description: Elastica is a PHP client for elasticsearch: http://elastica.io/
Fedora Account System Username: mooninite
Comment 1 Remi Collet 2015-10-13 04:22:05 EDT
From PHP Guidelines:
   A PSR-4 [2] compliant library would put its PHP files in
   /usr/share/php/<Vendor Name> in a PSR-0 compliant tree.

And used namespace is Elastica which should be the top level.
Comment 2 Remi Collet 2015-10-13 04:24:11 EDT
psr/log is required (see composer.json), and use "composer"  dependencies.
Comment 3 Remi Collet 2015-10-13 04:27:01 EDT
And it seems a good pratice to include autoload for dependencies
(ok psr/Log don't have one, but quite easy to ask its maintainer to add it)
Comment 4 Michael Cronenworth 2016-12-14 12:21:57 EST
With Fedora's change on bundled libraries I am not going to pursue this review.

Note You need to log in before you can comment on or make changes to this bug.