Bug 1271627
| Summary: | Creating a already deleted snapshot-clone deletes the corresponding snapshot. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Shashank Raj <sraj> | ||||
| Component: | snapshot | Assignee: | Avra Sengupta <asengupt> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Shashank Raj <sraj> | ||||
| Severity: | urgent | Docs Contact: | |||||
| Priority: | urgent | ||||||
| Version: | 3.7.5 | CC: | asengupt, bugs, gluster-bugs, rjoseph, sashinde | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | glusterfs-3.7.6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1272339 1273703 (view as bug list) | Environment: | |||||
| Last Closed: | 2015-11-16 07:12:04 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1272339, 1273703, 1275914 | ||||||
| Attachments: |
|
||||||
REVIEW: http://review.gluster.org/12364 (snapshot: Fix snapshot clone postvalidate) posted (#1) for review on master by Avra Sengupta (asengupt) REVIEW: http://review.gluster.org/12364 (snapshot: Fix snapshot clone postvalidate) posted (#2) for review on master by Avra Sengupta (asengupt) REVIEW: http://review.gluster.org/12406 (snapshot: Fix snapshot clone postvalidate) posted (#1) for review on release-3.7 by Avra Sengupta (asengupt) COMMIT: http://review.gluster.org/12406 committed in release-3.7 by Rajesh Joseph (rjoseph) ------ commit c11e3232963d28b4cdf73b694d82f7b6ed38894f Author: Avra Sengupta <asengupt> Date: Thu Oct 15 16:08:03 2015 +0530 snapshot: Fix snapshot clone postvalidate BackPort Of http://review.gluster.org/#/c/12364/ In glusterd_snapshot_clone_postvalidate(), we were deleting snap object and snap vol, by looking up snapname. Hence, it was deleting the orignal snapshot from which the clone was being created Instead it should fetch the clonename, the respective clone vol, and its corresponding snap object, and delete them. Also glusterd_snap_remove(), needs to differentiate a clone snap object from a snaphsot snap object, as in case of a clone snap object, we don't have any persisted data in /var/run/gluster/snaps/ and hence is shouldn't try to delete anything there. Change-Id: I02bb22a3898d5720e318a02d6cc32d25f75d317d BUG: 1271627 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/12364 Tested-by: NetBSD Build System <jenkins.org> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: mohammed rafi kc <rkavunga> Reviewed-by: Rajesh Joseph <rjoseph> (cherry picked from commit 59401a32de51cdb6c1a5a1208723e89e1a4abd30) Reviewed-on: http://review.gluster.org/12406 This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.6, please open a new bug report. glusterfs-3.7.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://www.gluster.org/pipermail/gluster-users/2015-November/024359.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |
Created attachment 1082804 [details] logs from one node Description of problem: Deleting and then creating the snapshot-clone with the same name deletes the snapshot as well Version-Release number of selected component (if applicable): glusterfs-3.7.5-0.19 How reproducible: Always Steps to Reproduce: 1. Create a dist-replica volume and start it. 2. Create a snapshot of this volume. 3. Create a clone from this snapshot. 4. Delete the clone and observe that the clone entries can still be seen under /run/gluster/snaps/clonename/../ and its is shows as mounted. 5. Create the clone again with the same name from the snapshot. 6. Observe that the creation of clone fails and inturn it deletes the snapshot from which we are trying to create the clone. Actual results: Creating a already deleted clone deletes the corresponding snapshot. Expected results: Failure while creating a clone should not delete the corresponding snapshot. Additional info: logs attached for the reference