Bug 127207
Summary: | [PATCH] keymap "fi" does not work properly | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jarkko <jval> |
Component: | rdesktop | Assignee: | Mark McLoughlin <markmc> |
Status: | CLOSED RAWHIDE | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 2 | CC: | pmatilai, scop, wtogami |
Target Milestone: | --- | Keywords: | i18n, Patch |
Target Release: | --- | ||
Hardware: | i686 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 1.3.1-5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2004-09-24 15:50:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 123268, 125270 |
Description
Jarkko
2004-07-04 00:39:02 UTC
Can anybody else confirm this problem? Confirmed. The keys @&<>' do not work in the shipped fi keymap for me. I have already posted a patch that fixes this for me upstream, it would be very nice to get this applied in RH/FC. http://sourceforge.net/tracker/index.php?func=detail&aid=959504&group_id=24366&atid=381349 Applied the patch. Everyhing seems to be working ok now, but I'm getting the following warning: WARNING: No translation for (keysym 0xfe03, ISO_Level3_Shift) Hmm, that warning must have been there already because the patch contained only additions. It might be a good idea though to check out what key should that (keysym 0xfe03, ISO_Level3_Shift) be so that we get rid of that warning. Actually, the patch removes 5 mappings (ie. those of the keys that did not work, some of which are duplicated in the original), it does not add anything. Oh, I was diffing the files wrong way. :) So I'm not sure if that warning was there before this patch or not. Propably it was (if I understand the keymap files correctly). My patch does not affect the ISO_Level3_Shift warning, it was there already before. AFAICS it's purely cosmetic, harmless warning, but nevertheless fixed in upstream CVS: http://cvs.sourceforge.net/viewcvs.py/rdesktop/rdesktop/keymaps/modifiers?r1=1.5&r2=1.6&diff_format=u It would be nice to include that fix as well in FC. (Oh, and ISO_Level3_Shift is AltGr, without the upstream patch a warning is printed every time it is pressed.) Thanks for that fix. Everything is now working exactly like it should. So just release a new rpm in updates with these two patches applied and this bug can be closed. :) By the way, that second ISO_Level3_Shift patch link says the following (I had to download the whole file instead): =================================================================== RCS file: /cvsroot/rdesktop/rdesktop/keymaps/modifiers,v retrieving revision 1.5 Unable to create temp directory: Permission denied Yeah, sf.net has the habit of breaking their CVS and/or CVSweb far too often. Anyway, the diff link in comment 7 works now; could we get these fixes in, at least for FC3, even better if also a FC2 erratum? That would result in many happy Finns :) Okay, warren seems to have added this patch. Seems to be in rdesktop-1.3.1-5 which is in FC3 test2. |