Bug 1272090
| Summary: | Review Request: nodejs-expect - Write better assertions | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
| Component: | Package Review | Assignee: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, piotr1212, vanmeeuwen+fedora |
| Target Milestone: | --- | Flags: | vanmeeuwen+fedora:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-15 15:20:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1272088, 1363789 | ||
| Bug Blocks: | 956806, 1364637, 1387531 | ||
|
Description
Jared Smith
2015-10-15 13:24:44 UTC
Title of but is nodejs-expect but the links point to nodejs-serve, please check what the correct module should be.
In nodejs-server there is a binary. This should be symlinked to /usr/bin/<name>
eg
in %install:
mkdir -p %{buildroot}%{_bindir}
ln -s %{nodejs_sitelib}/%{srcname}/cli.js %{buildroot}%{_bindir}/%{srcname}
and %files:
%{_bindir}/%{srcname}
Sorry, that was a mistake on my part. I'll open a separate review for nodejs-server. In the meantime, here are the Spec and SRPM for nodejs-expect: Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect-1.12.2-2.fc24.src.rpm Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect-1.20.2-1.fc24.src.rpm We're missing the build dependency of nodejs-is-equal (I can not find an existing review request for it either). Ask and ye shall recieve... See RHBZ#1363789 LICENSE.md is not marked as a license file. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect-1.20.2-2.fc26.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-expect In rawhide, closing bug |