Bug 1272090 - Review Request: nodejs-expect - Write better assertions
Review Request: nodejs-expect - Write better assertions
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jeroen van Meeuwen
Fedora Extras Quality Assurance
Depends On: 1272088 1363789
Blocks: nodejs-reviews Node-RED 1364637
  Show dependency treegraph
Reported: 2015-10-15 09:24 EDT by Jared Smith
Modified: 2016-10-21 04:13 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-08-15 11:20:46 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
vanmeeuwen+fedora: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Jared Smith 2015-10-15 09:24:44 EDT
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-serve/nodejs-serve.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-serve/nodejs-serve-1.4.0-1.fc23.src.rpm
Description: Write better assertions
Fedora Account System Username: jsmith
Comment 1 Piotr Popieluch 2015-10-27 08:44:19 EDT
Title of but is nodejs-expect but the links point to nodejs-serve, please check what the correct module should be.

In nodejs-server there is a binary. This should be symlinked to /usr/bin/<name>

in %install:
mkdir -p %{buildroot}%{_bindir}
ln -s %{nodejs_sitelib}/%{srcname}/cli.js %{buildroot}%{_bindir}/%{srcname}

and %files:
Comment 2 Jared Smith 2015-11-04 10:18:25 EST
Sorry, that was a mistake on my part.  I'll open a separate review for nodejs-server.  In the meantime, here are the Spec and SRPM for nodejs-expect:

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect-1.12.2-2.fc24.src.rpm
Comment 4 Jeroen van Meeuwen 2016-08-03 09:12:50 EDT
We're missing the build dependency of nodejs-is-equal (I can not find an existing review request for it either).
Comment 5 Jared Smith 2016-08-03 10:58:00 EDT
Ask and ye shall recieve... See RHBZ#1363789
Comment 6 Jeroen van Meeuwen 2016-08-07 06:03:36 EDT
LICENSE.md is not marked as a license file.
Comment 8 Gwyn Ciesla 2016-08-11 09:40:42 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-expect
Comment 9 Jared Smith 2016-08-15 11:20:46 EDT
In rawhide, closing bug

Note You need to log in before you can comment on or make changes to this bug.