Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-serve/nodejs-serve.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-serve/nodejs-serve-1.4.0-1.fc23.src.rpm Description: Write better assertions Fedora Account System Username: jsmith
Title of but is nodejs-expect but the links point to nodejs-serve, please check what the correct module should be. In nodejs-server there is a binary. This should be symlinked to /usr/bin/<name> eg in %install: mkdir -p %{buildroot}%{_bindir} ln -s %{nodejs_sitelib}/%{srcname}/cli.js %{buildroot}%{_bindir}/%{srcname} and %files: %{_bindir}/%{srcname}
Sorry, that was a mistake on my part. I'll open a separate review for nodejs-server. In the meantime, here are the Spec and SRPM for nodejs-expect: Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect-1.12.2-2.fc24.src.rpm
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect-1.20.2-1.fc24.src.rpm
We're missing the build dependency of nodejs-is-equal (I can not find an existing review request for it either).
Ask and ye shall recieve... See RHBZ#1363789
LICENSE.md is not marked as a license file.
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-expect/nodejs-expect-1.20.2-2.fc26.src.rpm
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-expect
In rawhide, closing bug