Bug 1272974
| Summary: | Fix regression detecting s390 CTC devices | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Thomas Haller <thaller> |
| Component: | NetworkManager | Assignee: | Rashid Khan <rkhan> |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.2 | CC: | bgalvani, dcbw, jklimes, lmiksik, lrintel, rkhan, thaller, vbenes |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | NetworkManager-1.0.6-22.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-11-19 11:06:32 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This is fixed upstream: master: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=8a6afe92c18dfefa91d057518be00b0127720fa5 nm-1-0: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2a8c93e940c3fdc5bb710f9fd1ec037e51524ed9 RHEL-7.1 would detect CTC devices based on the interface name. RHEL-7.2 would not detect them properly at all. This is a regression. Propose backporting the trivial fix. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-2315.html |
Originally and on RHEL-7.1, we detected s390 CTC devices like: if (arptype == 256) { /* Some s390 CTC-type devices report 256 for the encapsulation type * for some reason, but we need to call them Ethernet. FIXME: use * something other than interface name to detect CTC here. */ if (g_str_has_prefix (ifname, "ctc")) return_type (NM_LINK_TYPE_ETHERNET, "ethernet"); } Bug 1212118 and upstream commit [1] implemented better device detection for s390 CTC devices. This was later broken entirely due to commit [2]. [1] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=02c6a9334335d3ef32c6cc8fafc6cea235c80ffc [2] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=ddaea22332907c05222cbec1e1b4365689fbda9f