Bug 1212118 - NM doesn't configure CTC devices with predictable names
Summary: NM doesn't configure CTC devices with predictable names
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: NetworkManager
Version: 22
Hardware: s390x
OS: All
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Williams
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ZedoraTracker
TreeView+ depends on / blocked
 
Reported: 2015-04-15 15:07 UTC by Jan Stodola
Modified: 2015-10-19 14:08 UTC (History)
5 users (show)

Fixed In Version: NetworkManager-1.0.0-9.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-01 16:48:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
journalctl, predictable device name (119.15 KB, text/plain)
2015-04-15 15:10 UTC, Jan Stodola
no flags Details
journalctl, unpredictable device name (134.10 KB, text/plain)
2015-04-15 15:13 UTC, Jan Stodola
no flags Details

Description Jan Stodola 2015-04-15 15:07:39 UTC
Description of problem:
NM doesn't activate CTC devices that use predictable names (like slccw0.0.d000), but it works with unpredictable names (like ctc0).

A brief look into NM upstream sources showed that there is at least one place where NM relies on old unpredictable names of CTC devices:
http://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/src/platform/nm-linux-platform.c#n889

Version-Release number of selected component (if applicable):
NetworkManager-1.0.0-8.fc22.s390x.rpm

How reproducible:
always

Steps to Reproduce:
1. boot an s390x system having a CTC network device

Actual results:
CTC network device not activated

Expected results:
CTC network device up and running

Comment 1 Jan Stodola 2015-04-15 15:10:52 UTC
Created attachment 1014819 [details]
journalctl, predictable device name

Content of /etc/sysconfig/network-scripts/ifcfg-slccw0.0.d000:

NAME="slccw0.0.d000"
SUBCHANNELS="0.0.d000,0.0.d001"
NETTYPE="ctc"
OPTIONS="protocol=0"
DEVICE="slccw0.0.d000"
ONBOOT=yes
NETBOOT=yes
UUID="4b28b6f4-f6de-4778-b8b3-ac0f136da891"
BOOTPROTO=none
IPADDR="192.168.1.2"
PREFIX="32"
GATEWAY="192.168.1.1"
DNS1="10.16.36.29"
DNS2="10.11.5.19"
TYPE="Ethernet"

Comment 2 Jan Stodola 2015-04-15 15:13:49 UTC
Created attachment 1014820 [details]
journalctl, unpredictable device name

Booted with the "net.ifnames=0" kernel boot option.

Content of /etc/sysconfig/network-scripts/ifcfg-ctc0:

NAME="ctc0"
SUBCHANNELS="0.0.d000,0.0.d001"
NETTYPE="ctc"
OPTIONS="protocol=0"
DEVICE="ctc0"
ONBOOT=yes
NETBOOT=yes
UUID="4b28b6f4-f6de-4778-b8b3-ac0f136da891"
BOOTPROTO=none
IPADDR="192.168.1.2"
PREFIX="32"
GATEWAY="192.168.1.1"
DNS1="10.16.36.29"
DNS2="10.11.5.19"
TYPE=Ethernet

This case works fine.

Comment 3 Jirka Klimes 2015-04-20 16:52:35 UTC
Jan, thanks for the configuration files.

We should identify CTC devices by the driver name (ctcm) instead of the interface name, because it is changed by systemd nowadays.

Pushed a fix to an upstream branch jk/ctc-device-detect-rh1212118.

Comment 5 Dan Horák 2015-04-20 21:33:14 UTC
Jan, could you retry with rpms from http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1779720 ? They contain the patch Jirka wrote.

Comment 6 Jirka Klimes 2015-04-21 11:33:24 UTC
(In reply to Dan Horák from comment #5)
> Jan, could you retry with rpms from
> http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1779720 ? They
> contain the patch Jirka wrote.

I have installed the build to a test machine and CTC device with interface name slccw0.0.0150 is properly recognized as an Ethernet device and is activated.

Comment 7 Dan Horák 2015-04-29 09:01:55 UTC
Jirko, can we get an updated NM package in F-22 with the fix soon? The final freeze is getting closer.

Comment 8 Fedora Update System 2015-04-29 12:27:54 UTC
NetworkManager-1.0.0-9.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/NetworkManager-1.0.0-9.fc22

Comment 9 Fedora Update System 2015-04-30 11:48:37 UTC
Package NetworkManager-1.0.0-9.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing NetworkManager-1.0.0-9.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-7273/NetworkManager-1.0.0-9.fc22
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2015-05-01 16:48:50 UTC
NetworkManager-1.0.0-9.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Jan Stodola 2015-05-14 15:45:03 UTC
Thanks Jirko,
retested with NetworkManager-1.0.2-1.fc22.s390x, it works fine.

Comment 12 Thomas Haller 2015-10-19 10:39:39 UTC
Detection of CTC devices regressed on F22 and F23 due to NM-1.0.6.

This is fixed upstream with commit
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=8a6afe92c18dfefa91d057518be00b0127720fa5


See also RHEL-7.2 bug 1272974.


(will be fixed again in F22 soon)

Comment 13 Thomas Haller 2015-10-19 14:08:20 UTC
(In reply to Thomas Haller from comment #12)
> (will be fixed again in F22 soon)

will be fixed by NetworkManager-1.0.6-7.fc22

https://bodhi.fedoraproject.org/updates/FEDORA-2015-6c051fe008


Note You need to log in before you can comment on or make changes to this bug.