Bug 1274423

Summary: [DOC] slapi_valueset_add_value_ext must return int
Product: Red Hat Directory Server Reporter: Noriko Hosoi <nhosoi>
Component: Doc-plugin-programming-guideAssignee: Marc Muehlfeld <mmuehlfe>
Status: CLOSED DEFERRED QA Contact: Viktor Ashirov <vashirov>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 10.0CC: lkrispen, nkinder, rmeggins, wibrown
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-20 07:20:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Noriko Hosoi 2015-10-22 16:52:02 UTC
If slapi_valueset_add_value_ext is used with the SLAPI_VALUE_FLAG_DUPCHECK flag, the caller is responsible for knowing how to cleanup the given value if there is an error.  For example, if the flags are SLAPI_VALUE_FLAG_DUPCHECK|SLAPI_VALUE_FLAG_PASSIN, slapi_valueset_add_value_ext does not know if it needs to free the given value or not.  The caller should be responsible.
Right now, no code in 389 uses SLAPI_VALUE_FLAG_DUPCHECK|SLAPI_VALUE_FLAG_PASSIN, but since slapi_valueset_add_value_ext is part of the public SLAPI, someone could use it and cause a memory leak or other problem.

https://fedorahosted.org/389/ticket/47506#comment:10
We need to update the plugin guide documenting the return code and the new flag for DUPCHECK

Comment 1 Noriko Hosoi 2016-05-13 22:26:10 UTC
Pushing it to FUTURE.