Bug 1274423 - [DOC] slapi_valueset_add_value_ext must return int
Summary: [DOC] slapi_valueset_add_value_ext must return int
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Red Hat Directory Server
Classification: Red Hat
Component: Doc-plugin-programming-guide
Version: 10.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Marc Muehlfeld
QA Contact: Viktor Ashirov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-10-22 16:52 UTC by Noriko Hosoi
Modified: 2020-09-13 20:45 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-20 07:20:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github 389ds 389-ds-base issues 843 0 None None None 2020-09-13 20:45:09 UTC

Description Noriko Hosoi 2015-10-22 16:52:02 UTC
If slapi_valueset_add_value_ext is used with the SLAPI_VALUE_FLAG_DUPCHECK flag, the caller is responsible for knowing how to cleanup the given value if there is an error.  For example, if the flags are SLAPI_VALUE_FLAG_DUPCHECK|SLAPI_VALUE_FLAG_PASSIN, slapi_valueset_add_value_ext does not know if it needs to free the given value or not.  The caller should be responsible.
Right now, no code in 389 uses SLAPI_VALUE_FLAG_DUPCHECK|SLAPI_VALUE_FLAG_PASSIN, but since slapi_valueset_add_value_ext is part of the public SLAPI, someone could use it and cause a memory leak or other problem.

https://fedorahosted.org/389/ticket/47506#comment:10
We need to update the plugin guide documenting the return code and the new flag for DUPCHECK

Comment 1 Noriko Hosoi 2016-05-13 22:26:10 UTC
Pushing it to FUTURE.


Note You need to log in before you can comment on or make changes to this bug.