Bug 1275391
| Summary: | Review Request: wbar - A quick launch bar | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Attila Zsolt Sajo <sajozsattila> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, projects.rg, sajozsattila |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-06 21:26:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Attila Zsolt Sajo
2015-10-26 18:38:33 UTC
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11585888 Output of rpmlint -i wbar.spec wbar-2.3.4-1.fc21.i686.rpm wbar-2.3.4-1.fc21.src.rpm: 2 packages and 1 specfiles checked; 0 errors, 0 warnings. sajozsattila's scratch build of wbar-2.3.4-1.fc21.src.rpm for f22 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11602428 I have updated the spec file, the rpmlint and koji result is show same. williamjmorenor's scratch build of wbar-2.3.4-1.fc21.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11630491 Are you going to epel5? If not, there is no need of rm -rf $RPM_BUILD_ROOT in %%install. Note than the current spec build fine in epel6, epel7 and current Fedora: http://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build/131391/ Where is the license file? You must use the %license macro to handle the COPYING file in the tarball. Note than for epel6 you need to define the %license macro in %%files with %files %{!?_licensedir:%global license %%doc} %license COPYING Where are the docs files? You must use the %doc macro to handle the AUTHORS ChangeLog INSTALL README NEWS THANKS and TODO files in the tarball. Consider to create a -docs subpackage. Any update here? It seems we can close here. Please feel free to reopen if you're still interested in this package. |