Bug 1275391 - Review Request: wbar - A quick launch bar
Review Request: wbar - A quick launch bar
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2015-10-26 14:38 EDT by Attila Zsolt Sajo
Modified: 2017-02-06 16:26 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-02-06 16:26:33 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Attila Zsolt Sajo 2015-10-26 14:38:33 EDT
Spec URL: http://landscape.geo.klte.hu/sajozsattila/Fedora_packages/wbar.spec
SRPM URL: http://landscape.geo.klte.hu/sajozsattila/Fedora_packages/wbar-2.3.4-1.fc21.src.rpm

Description: wbar is a quick launch bar.
* It's cool eye candy
* It's designed with speed in mind
* It's coded in c++ using imlib2
* It's lite & fast


Authors:
--------
   Rodolfo Granata


Fedora Account System Username: sajozsattila
Comment 1 Attila Zsolt Sajo 2015-10-26 14:41:13 EDT
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11585888


Output of rpmlint -i wbar.spec wbar-2.3.4-1.fc21.i686.rpm wbar-2.3.4-1.fc21.src.rpm:

2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Comment 2 Upstream Release Monitoring 2015-10-27 16:14:30 EDT
sajozsattila's scratch build of wbar-2.3.4-1.fc21.src.rpm for f22 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11602428
Comment 3 Attila Zsolt Sajo 2015-10-27 16:33:50 EDT
I have updated the spec file, the rpmlint and koji result is show same.
Comment 4 Upstream Release Monitoring 2015-10-29 15:01:41 EDT
williamjmorenor's scratch build of wbar-2.3.4-1.fc21.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11630491
Comment 5 William Moreno 2015-10-29 17:11:42 EDT
Are you going to epel5? If not, there is no need of rm -rf $RPM_BUILD_ROOT in %%install.

Note than the current spec build fine in epel6, epel7 and current Fedora:
http://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build/131391/

Where is the license file? You must use the %license macro to handle the COPYING file in the tarball. Note than for epel6 you need to define the %license macro in %%files with 

%files 
%{!?_licensedir:%global license %%doc}
%license COPYING

Where are the docs files? You must use the %doc macro to handle the AUTHORS ChangeLog INSTALL README NEWS THANKS and TODO files in the tarball.

Consider to create a -docs subpackage.
Comment 6 William Moreno 2016-01-06 14:34:12 EST
Any update here?
Comment 7 Raphael Groner 2017-02-06 16:26:33 EST
It seems we can close here. Please feel free to reopen if you're still interested in this package.

Note You need to log in before you can comment on or make changes to this bug.