Bug 1275836

Summary: Stoping a vm during live merge will cause the snapshot's disk to be in ILLEGAL state
Product: [oVirt] ovirt-engine Reporter: Raz Tamir <ratamir>
Component: BLL.StorageAssignee: Ala Hino <ahino>
Status: CLOSED NOTABUG QA Contact: Aharon Canan <acanan>
Severity: high Docs Contact:
Priority: high    
Version: 3.6.0.2CC: ahino, amureini, bugs, mgoldboi, ratamir, tnisan
Target Milestone: ovirt-3.6.6Keywords: Automation, Reopened
Target Release: ---Flags: amureini: ovirt-3.6.z?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-14 08:57:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine and vdsm logs
none
new logs
none
screenshots none

Description Raz Tamir 2015-10-27 21:51:00 UTC
Created attachment 1087060 [details]
engine and vdsm logs

Description of problem:
Live merge will fail if we will stop the vm during the operation (expected result) and the snapshot's disks will mark as ILLEGAL.
The snapshot is unusable - engine.log:
" The following attached disks are in ILLEGAL status: virtio_raw_False_nfs_disk_6058, virtio_cow_True_nfs_disk_6058, live_merge_vm_nfs_Disk_glance_6058, virtio_scsi_raw_False_nfs_disk_6058, virtio_scsi_raw_True_nfs_disk_6058, virtio_raw_True_nfs_disk_6058, virtio_scsi_cow_True_nfs_disk_6058 - please remove them and try again."


Version-Release number of selected component (if applicable):
rhevm-3.6.0.2-0.1.el6.noarch
vdsm-4.17.10-5.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. Create vm with 4 disks
2. create 3 snapshots
3. remove the second snapshot
4. stop the vm

Actual results:
The snapshot's disk marks as ILLEGAL state

Expected results:


Additional info:

Comment 1 Allon Mureinik 2015-10-28 12:50:37 UTC
Raz, just to clarify - is the DISK marked as illegal or just the SNAPSHOT we we're trying to merge?
If it's the former, this is a nasty bug. If it's the latter, this is by design.

Comment 2 Red Hat Bugzilla Rules Engine 2015-10-28 12:50:43 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 3 Raz Tamir 2015-10-28 14:47:48 UTC
Allon,
I'm talking about the snapshot (disks sub tub of snapshot).
So I guess this this is by design

Comment 4 Raz Tamir 2016-03-30 18:29:26 UTC
Allon,
I just realized, from your last comment, that "this is a nasty bug".
The disks of the vm become ILLEGAL.

Comment 5 Greg Padgett 2016-03-30 18:32:38 UTC
In some cases, the disks becoming illegal is by design as well--but regardless we should take a look to ensure there's nothing surprising going on.

Comment 6 Red Hat Bugzilla Rules Engine 2016-03-30 22:12:58 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 7 Ala Hino 2016-04-11 07:09:14 UTC
Raz,

I tried to reproduce this one but with no success. In all my attempts, the snapshot, as expected, becomes ILLEGAL but the disk remains OK.

Would appreciate if you can try again and maybe provide some more info in order to reproduce.

Comment 8 Raz Tamir 2016-04-11 07:36:45 UTC
Created attachment 1145842 [details]
new logs

Ala,
I'm attaching new engine and vdsm logs + screenshot.

After the snapshot's disks become ILLEGAL I tried to preview the snapshot and got the error:
Status: 500
Reason: Internal Server Error
Detail: [Cannot preview Snapshot. The following attached disks are in ILLEGAL status: virtio_cow_True_nfs_disk_6058, virtio_raw_True_nfs_disk_6058, virtio_scsi_raw_True_nfs_disk_6058, live_merge_vm_nfs_6058_Disk_0_6058, virtio_scsi_cow_True_nfs_disk_6058 - please remove them and try again.]

Comment 9 Raz Tamir 2016-04-11 07:38:20 UTC
Created attachment 1145843 [details]
screenshots

Comment 10 Allon Mureinik 2016-04-14 08:57:16 UTC
(In reply to ratamir from comment #8)
> Created attachment 1145842 [details]
> new logs
> 
> Ala,
> I'm attaching new engine and vdsm logs + screenshot.
> 
> After the snapshot's disks become ILLEGAL I tried to preview the snapshot
> and got the error:
> Status: 500
> Reason: Internal Server Error
> Detail: [Cannot preview Snapshot. The following attached disks are in
> ILLEGAL status: virtio_cow_True_nfs_disk_6058,
> virtio_raw_True_nfs_disk_6058, virtio_scsi_raw_True_nfs_disk_6058,
> live_merge_vm_nfs_6058_Disk_0_6058, virtio_scsi_cow_True_nfs_disk_6058 -
> please remove them and try again.]

If a live merge starts and fails the DISK SNAPSHOT should be marked as illegal, as it no longer represents a consistent point in time.
Such a state can't be previewed, which is fine.

There's no bug here.

Comment 11 Ala Hino 2016-05-04 08:18:14 UTC
Resolving needinfo as the required info provided by Allon: https://bugzilla.redhat.com/1275836#c10