Created attachment 1087060 [details] engine and vdsm logs Description of problem: Live merge will fail if we will stop the vm during the operation (expected result) and the snapshot's disks will mark as ILLEGAL. The snapshot is unusable - engine.log: " The following attached disks are in ILLEGAL status: virtio_raw_False_nfs_disk_6058, virtio_cow_True_nfs_disk_6058, live_merge_vm_nfs_Disk_glance_6058, virtio_scsi_raw_False_nfs_disk_6058, virtio_scsi_raw_True_nfs_disk_6058, virtio_raw_True_nfs_disk_6058, virtio_scsi_cow_True_nfs_disk_6058 - please remove them and try again." Version-Release number of selected component (if applicable): rhevm-3.6.0.2-0.1.el6.noarch vdsm-4.17.10-5.el7ev.noarch How reproducible: 100% Steps to Reproduce: 1. Create vm with 4 disks 2. create 3 snapshots 3. remove the second snapshot 4. stop the vm Actual results: The snapshot's disk marks as ILLEGAL state Expected results: Additional info:
Raz, just to clarify - is the DISK marked as illegal or just the SNAPSHOT we we're trying to merge? If it's the former, this is a nasty bug. If it's the latter, this is by design.
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Allon, I'm talking about the snapshot (disks sub tub of snapshot). So I guess this this is by design
Allon, I just realized, from your last comment, that "this is a nasty bug". The disks of the vm become ILLEGAL.
In some cases, the disks becoming illegal is by design as well--but regardless we should take a look to ensure there's nothing surprising going on.
Raz, I tried to reproduce this one but with no success. In all my attempts, the snapshot, as expected, becomes ILLEGAL but the disk remains OK. Would appreciate if you can try again and maybe provide some more info in order to reproduce.
Created attachment 1145842 [details] new logs Ala, I'm attaching new engine and vdsm logs + screenshot. After the snapshot's disks become ILLEGAL I tried to preview the snapshot and got the error: Status: 500 Reason: Internal Server Error Detail: [Cannot preview Snapshot. The following attached disks are in ILLEGAL status: virtio_cow_True_nfs_disk_6058, virtio_raw_True_nfs_disk_6058, virtio_scsi_raw_True_nfs_disk_6058, live_merge_vm_nfs_6058_Disk_0_6058, virtio_scsi_cow_True_nfs_disk_6058 - please remove them and try again.]
Created attachment 1145843 [details] screenshots
(In reply to ratamir from comment #8) > Created attachment 1145842 [details] > new logs > > Ala, > I'm attaching new engine and vdsm logs + screenshot. > > After the snapshot's disks become ILLEGAL I tried to preview the snapshot > and got the error: > Status: 500 > Reason: Internal Server Error > Detail: [Cannot preview Snapshot. The following attached disks are in > ILLEGAL status: virtio_cow_True_nfs_disk_6058, > virtio_raw_True_nfs_disk_6058, virtio_scsi_raw_True_nfs_disk_6058, > live_merge_vm_nfs_6058_Disk_0_6058, virtio_scsi_cow_True_nfs_disk_6058 - > please remove them and try again.] If a live merge starts and fails the DISK SNAPSHOT should be marked as illegal, as it no longer represents a consistent point in time. Such a state can't be previewed, which is fine. There's no bug here.
Resolving needinfo as the required info provided by Allon: https://bugzilla.redhat.com/1275836#c10